User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090716 Ubuntu/9.04 (jaunty) Shiretoko/3.5.1 Build Identifier: My inline threading work (Bug 506182) requires the cases for handling opcodes to be moved into a separate file so that it can be included in different contexts (once in the main interpreter loop, once to create functions). Making this move now would simplify merging new changes with the work in progress inline threading code and the eventual review/landing of the inline threading. Reproducible: Always

This patch moves opcode definitions to jsops.cpp and includes it from the interpreter loop. It should be performance neutral.

This patch performs the slight amount of rearranging done before the actual move.

A very minor update (putting a closing comment after an #endif)

A very minor update (putting a closing comment after an #endif)

Who all might be patching the interpreter? /me raises hand, but can wait till after this lands. I'm about to r= the patch here. Any reason to wait, or concerns about obscure C++ optimization issues, or whatever? /be

I say we go for it. If there are bizarre optimizer quirks, we can look at doing all-one-file or similar later.

Sure, just cc'ing peers for a change. /be

Comment on attachment 392405 [details] [diff] [review] Patch to move opcode case definitions to a new file r=me, thanks for your patience. Kind of an rs (rubberstamp), do what you need to do given any patches that landed ahead of this. /be

Nothing in my queue is touching interp. Go ahead.

Pushed to TM as e9c00ca58788.