Closed
Bug 508066
Opened 15 years ago
Closed 15 years ago
[mozmill] - Form AutoComplete respects source for autocomplete equals off
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: aakashd, Assigned: aakashd)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
aakashd
:
review+
|
Details | Diff | Splinter Review |
The test script goes to the english google home page runs a search for "mozillazine", goes back to the home page and checks if firefox's browser implementation of autocomplete is not enabled.
Litmus test case represented:
* Testcase ID #7054 - Form AutoComplete respects source for autocomplete="off"
Attachment #392285 -
Flags: review?(hskupin)
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → adesai
Assignee | ||
Updated•15 years ago
|
Summary: [mozmill] - Form AutoComplete respects source for autocomplete="off" → [mozmill] - Form AutoComplete respects source for autocomplete equals off
Comment 1•15 years ago
|
||
FWIW, this stuff is already well covered by mochitests.
Assignee | ||
Comment 2•15 years ago
|
||
We know, but our MozMill Test Framework (i.e. porting as many manual testcases from litmus onto MozMill) is being created and it doesn't hurt to double up like this.
Comment 3•15 years ago
|
||
Justin, can you please point me to the tests we have in mochitest? I would vote to remove this testcase from Litmus due to our much better coverage of this area since the testcase on Litmus has been created.
Tracy, any objections?
Updated•15 years ago
|
Attachment #392285 -
Attachment mime type: application/x-javascript → text/plain
Comment 4•15 years ago
|
||
Justin, are those under http://mxr.mozilla.org/mozilla-central/source/toolkit/components/autocomplete/tests/unit/?
I cannot find a real world example like we do with Google search. Is there such a specific mochitest in the repository?
Updated•15 years ago
|
Attachment #392285 -
Flags: review?(hskupin) → review-
Comment 5•15 years ago
|
||
Comment on attachment 392285 [details]
testFormManager/testSourceAutoCompleteOff.js
> // Verify autocomplete=off
> var popDownAutoCompList = new elementslib.Lookup(controller.window.content.document, '/id("main-window")/id("mainPopupSet")/id("PopupAutoComplete")/anon({"anonid":"tree"})/{"class":"autocomplete-treebody"}');
>
> controller.type(searchField, "mozi");
> controller.sleep(gDelay);
> controller.assertNodeNotExist(popDownAutoCompList);
I have tested it in a couple of ways but for now I don't have a real solution how we can this make passing. If you replace the url with another page which has autocomplete not turned off the test still pass. Using assertElementVisible doesn't work neither. Looks like the treechildren element and the popup itself are always visible. Probably we have to check the tree itself. And this is blocked by the missing templetized tree support for Mozmill.
Comment 6•15 years ago
|
||
Clint, this will be one more instance for the missing templetized tree support. Probably we should use getNode() and work on the element itself. We could check the number of treechildren. Or would there be a better way?
Depends on: 477079
Comment 7•15 years ago
|
||
(In reply to comment #3)
> Justin, can you please point me to the tests we have in mochitest? I would vote
> to remove this testcase from Litmus due to our much better coverage of this
> area since the testcase on Litmus has been created.
>
> Tracy, any objections?
Interestingly enough, I pulled that test case from the BFT's over the weekend during my cleanup. I think it's fine to leave enabled in the Litmus FFT's.
Aakash, unless you've put a ton of work into this Mozmill test case, drop it from your todo list.
https://litmus.mozilla.org/show_test.cgi?id=5922
and
https://litmus.mozilla.org/show_test.cgi?id=6010
should be the primary target in this subgroup.
Assignee | ||
Comment 8•15 years ago
|
||
Tracy, I'm actually done with the testscripts (mentioned in your comments) pending the fix from the dependency on this bug. So, I have put some work into it. At the least, we can leave it as it'll be one less testcase to script once we start on FFT's.
Comment 9•15 years ago
|
||
It's hard to say how much work it needs to call it ready. As long as we don't have any progress with templetized trees and no other path to test we should leave it in the queue for later usage.
Assignee | ||
Comment 10•15 years ago
|
||
Aye, agreed . Let's wait on a decision after the required work has been put into templetized trees.
Comment 11•15 years ago
|
||
(In reply to comment #4)
> Justin, are those under
> http://mxr.mozilla.org/mozilla-central/source/toolkit/components/autocomplete/tests/unit/?
No, not quite.
The existing satchel tests for autocomplete=off are in /toolkit/components/satchel/test/, both test_form_autocomplete.html and test_form_submission.html.
Comment 12•15 years ago
|
||
Thanks Justin. But as you have seen we wanna have this test in Mozmill too.
(In reply to comment #10)
> Aye, agreed . Let's wait on a decision after the required work has been put
> into templetized trees.
Lets see if this is really necessary. Today I will check bug 506275 so we could use the controller.select function eventually.
Assignee | ||
Comment 13•15 years ago
|
||
Just like with bug 50912 , this testscript is now working. Reviewed it with ctalbert and it's good to go. I'm not sure what happened.
Attachment #392285 -
Attachment is obsolete: true
Attachment #394521 -
Flags: review?(hskupin)
Comment 14•15 years ago
|
||
Comment on attachment 394521 [details] [diff] [review]
testFormManager/testSourceAutoCompleteOff.js
Does not work. I will try to get it fixed now.
Attachment #394521 -
Flags: review?(hskupin) → review-
Comment 15•15 years ago
|
||
This way works perfect. I also made some smaller changes while working on the test.
Attachment #394521 -
Attachment is obsolete: true
Attachment #395329 -
Flags: review?(adesai)
Assignee | ||
Comment 16•15 years ago
|
||
Comment on attachment 395329 [details] [diff] [review]
Patch final
The testscript looks good and runs perfectly on a quick run for myself.
Attachment #395329 -
Flags: review?(adesai) → review+
Comment 17•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 18•14 years ago
|
||
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Form Manager → Mozmill Tests
Product: Toolkit → Mozilla QA
QA Contact: form.manager → mozmill-tests
Version: Trunk → unspecified
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•