Closed
Bug 508526
Opened 15 years ago
Closed 15 years ago
Make gDownloadLastDir smarter
Categories
(Firefox :: Private Browsing, defect)
Firefox
Private Browsing
Tracking
()
RESOLVED
FIXED
Firefox 3.7a1
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
Followup from bug 499733 comment 11.
The gDownloadLastDir object in toolkit needs to be smarter, so that it saves the nsIFile as either a pref value or an in-memory value based on the current private browsing mode.
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #395032 -
Flags: review?(mconnor)
Assignee | ||
Updated•15 years ago
|
Whiteboard: [needs r=mconnor]
Comment 2•15 years ago
|
||
Comment on attachment 395032 [details] [diff] [review]
Patch (v1)
Looks good, thanks.
Attachment #395032 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 3•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs r=mconnor]
Target Milestone: --- → Firefox 3.7a1
Assignee | ||
Updated•15 years ago
|
Whiteboard: [not needed for 1.9.2]
Assignee | ||
Updated•15 years ago
|
status1.9.1:
--- → wontfix
Assignee | ||
Comment 4•15 years ago
|
||
The developer docs for this module should be similar to that of bug 499733.
Keywords: dev-doc-needed
Comment 5•15 years ago
|
||
To what does "[not needed for 1.9.2]" refer in the whiteboard here?
Assignee | ||
Comment 6•15 years ago
|
||
(In reply to comment #5)
> To what does "[not needed for 1.9.2]" refer in the whiteboard here?
It means that this patch is not important enough to take for 1.9.2. That was before the status1.9.2 flag. :-)
status1.9.2:
--- → wontfix
Whiteboard: [not needed for 1.9.2]
Updated•15 years ago
|
Whiteboard: [doc-waiting-1.9.3]
Comment 7•14 years ago
|
||
Documented:
https://developer.mozilla.org/en/JavaScript/Code_modules/DownloadLastDir.jsm
Added to the list here:
https://developer.mozilla.org/en/Firefox_4_for_developers#JavaScript_code_modules
And here:
https://developer.mozilla.org/en/JavaScript/Code_modules
Keywords: dev-doc-needed → dev-doc-complete
Whiteboard: [doc-waiting-1.9.3]
You need to log in
before you can comment on or make changes to this bug.
Description
•