Closed
Bug 508605
Opened 15 years ago
Closed 15 years ago
NetUtil.asyncCopy does not handle nsISafeOutputStreams correctly
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.9.2b1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
benjamin
:
review+
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•15 years ago
|
||
In order to do this, I'd need to move nsISafeOutputStream into xpcom/io and out of necko.
|
|
Assignee | |
Comment 2•15 years ago
|
||
This does the trick, and I'm pretty sure it's right. I added some comments to make what is going on in nsAStreamCopier::Process a little bit clearer since it wasn't obvious to me what was going on at first.
bsmedberg can review the changes to xpcom/, and bz the unit test I've added in netwerk/.
Attachment #392771 -
Flags: review?(bzbarsky)
Attachment #392771 -
Flags: review?(benjamin)
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review bsmedberg][needs review bz]
|
||
Comment 3•15 years ago
|
||
Comment on attachment 392771 [details] [diff] [review]
v1.0
r=bzbarsky
Attachment #392771 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review bsmedberg][needs review bz] → [needs review bsmedberg]
|
||
Updated•15 years ago
|
Attachment #392771 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review bsmedberg]
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2b1
|
|
Assignee | |
Comment 5•15 years ago
|
||
I thought this had passed tests locally, but tinderbox really doesn't like it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 6•15 years ago
|
||
This bug appears to have been wrongfully blamed (and I hadn't backed it out yet). Closing again.
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•