Closed Bug 508685 Opened 15 years ago Closed 15 years ago

Remove last parameter of defineProperty op

Categories

(Core :: JavaScript Engine, defect)

Other Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

It's an optional out parameter that receives the JSProperty pointer. A glance at all the call sites reveals everyone's passing null except for one in the interpreter, in CASE(JSOP_DEFVAR). That one could be changed to call js_DefineNativeProperty directly, if it's true that fp->varobj is always a native object (with the normal native defineProperty op). array_defineProperty ignores this out parameter, leaving it uninitialized. If we were using it, I think array_dropProperty would be asserting.
Attached patch v1 (deleted) — Splinter Review
Assignee: general → jorendorff
Attachment #396616 - Flags: review?(gal)
Comment on attachment 396616 [details] [diff] [review] v1 Drive by r=me! /be
Attachment #396616 - Flags: review+
Brendan grabbed it as I was reviewing. No objections here either.
Whiteboard: fixed-in-tracemonkey
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: