Closed
Bug 509929
Opened 15 years ago
Closed 15 years ago
Reference cycle between nsProgressNotificationProxy and nsHttpChannel on channel redirect
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: bholley, Assigned: bholley)
References
Details
(Keywords: memory-leak)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Some slight modification (not sure which one) in the behavior of imgRequest that I implemented in bug 435296 uncovered a memory leak that can be reproduced reliably by running
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug336682_2.xul
with the current bug 435296 patch applied.
I banged my head against it for about a day and a half before convincing myself that I wasn't doing anything wrong imagelib side and that it was probably a necko bug. I then had the bright idea of asking biesi to look at it, and he diagnosed the problem in 15 minutes.
Basically, we need to set mCallbacks and mProgressSink to null here:
http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/src/nsHttpChannel.cpp#1281
nsProgressEventSink should also implement nsIChannelEventSink so that it can update mChannel when the channel changes.
Patch coming soon.
Assignee | ||
Comment 1•15 years ago
|
||
Added a patch. Flagging biesi for review.
Attachment #394014 -
Flags: review?(cbiesinger)
Comment 2•15 years ago
|
||
Comment on attachment 394014 [details] [diff] [review]
patch v1
+ // ..and the old callbacks
maybe make that 3 dots for consistency?
Attachment #394014 -
Flags: review?(cbiesinger) → review+
Comment 3•15 years ago
|
||
fwiw, this is not an issue with redirects in general, just when the redirect is due to PAC. (and in that case, it could also cause memory leaks in other places)
Assignee | ||
Comment 5•15 years ago
|
||
pushed to mc in 7b05cc2cb9ee.
Resolving as fixed.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•