Closed Bug 510650 Opened 15 years ago Closed 15 years ago

mingw compilation failure in widget/src/windows/WindowHook.h

Categories

(Core :: Widget: Win32, defect, P2)

x86
Windows 7
defect

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: Mook, Unassigned)

References

Details

Attachments

(1 file)

Attached patch friend class ::nsWindow (deleted) — Splinter Review
bug 507736 added mozilla::widget::WindowHook (for Win32); this fixes compilation on mingw. friend nsWindow needs to refer to the global class, not mozilla::widget::nsWindow (which doesn't exist)
Attachment #394628 - Flags: review?(jmathies)
Attachment #394628 - Flags: review?(jmathies) → review+
Attachment #394628 - Flags: superreview?(roc)
Attachment #394628 - Flags: superreview?(roc) → superreview+
r/sr, build only change (doesn't need tests), windows only, tested on msvc8 + gcc. marking checkin-needed, thanks for the reviews, guys! :D
Keywords: checkin-needed
Woops, that bustage fix wasn't for this bug.
Blocks a blocking bug (Windows 7 tab preview) amazingly enough, thus is a blocker itself.
Flags: blocking1.9.2+
Priority: -- → P2
Whiteboard: [c-n: m-1.9.2]
Whiteboard: [c-n: m-1.9.2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: