Closed
Bug 511051
Opened 15 years ago
Closed 15 years ago
TM/nanojit: use NULL as the condition for unconditional guards, again
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | beta1-fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
(deleted),
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
This is a follow-up to bug 504705 -- some non-NULL conditions have crept back in. This patch removes them and also adds an assertion to LirBufWriter::insGuard() that guarantees this won't happen again.
Attachment #395000 -
Flags: review?(gal)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 395000 [details] [diff] [review]
patch
NanoAssert((op != LIR_loop) && (op != LIR_x) && (op != LIR_barrier)) || !c);
Attachment #395000 -
Flags: review?(gal) → review+
|
Assignee | |
Comment 2•15 years ago
|
||
(In reply to comment #1)
> (From update of attachment 395000 [details] [diff] [review])
> NanoAssert((op != LIR_loop) && (op != LIR_x) && (op != LIR_barrier)) || !c);
This is shorter, but harder to read than the original version, IMHO.
|
|
Assignee | |
Comment 3•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/3f9deefa7324
(Slightly modified to account for LIR_loop no longer existing.)
Whiteboard: fixed-in-tracemonkey
|
||
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Comment 5•15 years ago
|
||
status1.9.2:
--- → beta1-fixed
Flags: wanted1.9.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•