Closed
Bug 511240
Opened 15 years ago
Closed 15 years ago
Provide feedback for loading of content within content tabs
Categories
(Thunderbird :: Toolbars and Tabs, defect)
Thunderbird
Toolbars and Tabs
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b4
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
standard8
:
review+
standard8
:
approval-thunderbird3+
|
Details | Diff | Splinter Review |
At the moment there is no indication present whilst loading content within content tabs. We should provide a mechanism that we can use and extensions can benefit from as well.
Most of this is easily copied from tabbrowser. This requires nsBrowserStatusFilter to be included in the component list for which I'm just about to file a bug. The benefit of the filter is that it reduces the amount of calls that we get telling us about updates.
Attachment #395165 -
Flags: review?(bugmail)
|
Assignee | |
Comment 1•15 years ago
|
||
The core patch is in bug 511242.
|
||
Comment 2•15 years ago
|
||
Comment on attachment 395165 [details] [diff] [review]
Thunderbird Fix
r=asuth if you move the listener object definition out to a 'proper' (per our conventions) class. (Constructor with attached prototype.) Also, please provide explicit function names...
Attachment #395165 -
Flags: review?(bugmail) → review+
|
||
Updated•15 years ago
|
Whiteboard: [needs updated patch]
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs updated patch] → [needs updated patch][waiting on 511242 to land on 191]
|
|
Assignee | |
Comment 3•15 years ago
|
||
Updated patch fixed as per review comments and fixed for the odd change that has gone into the content tabs since we submitted it.
I'm giving myself a+ on this as I want to get it in so that we can test the loading indication (on at least the what's new page) and we can start building on it.
Attachment #395165 -
Attachment is obsolete: true
Attachment #399989 -
Flags: review+
Attachment #399989 -
Flags: approval-thunderbird3+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [needs updated patch][waiting on 511242 to land on 191]
You need to log in
before you can comment on or make changes to this bug.
Description
•