Closed
Bug 511374
Opened 15 years ago
Closed 15 years ago
fix test_results-as-visit.js
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | beta1-fixed |
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
This test is wrong, even if actually it passes, it is based on wrong assumptions about the structure of the query and the fact one can add multiple visits with the same visit time.
Attachment #395285 -
Flags: review?(dietrich)
|
||
Comment 1•15 years ago
|
||
this patch changes the query as well, what is that change for?
|
Assignee | |
Comment 2•15 years ago
|
||
if you check the query you will notice that condition is repeated 2 times in the same where, and that's useless.
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 395285 [details] [diff] [review]
patch v1.0
so it is! r=me.
Attachment #395285 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
|
|
Assignee | |
Comment 5•15 years ago
|
||
status1.9.2:
--- → beta1-fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•