Closed Bug 511888 Opened 15 years ago Closed 15 years ago

SimpleTest/SimpleTest.js: report stack too in |window.onerror|

Categories

(Testing :: Mochitest, enhancement)

Product:
Testing
Component:
Mochitest
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(
URL
)

Details

(Whiteboard: [fixed1.9.2b1 fixed1.9.1.4])

Attachments

(2 files, 1 obsolete file)

(Av2) Do (the little) that can be done [Checkin: Comment 6 & 8 & 11]
(deleted), patch
rcampbell
: review+
Details | Diff | Splinter Review
(Bv1) additional nits [Checkin: Comment 9 & 10 & 12]
(deleted), patch
rcampbell
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch (Av1) Do (the little) that can be done (obsolete) (deleted) — — Splinter Review
(try+catch) 'Error' documentation: https://developer.mozilla.org/en/Core_JavaScript_1.5_Reference/Global_Objects/Error 'window.onerror' documentation: https://developer.mozilla.org/en/DOM/window.onerror [1] That said, it turned out my initial hope was actually bug 355430 :-/ [1] That page says the 3rd param is an "Error code", but http://www.javascriptkit.com/javatutors/error3.shtml (for example) says it's a line number (and test seems to confirm that). Should I update MDC? Should I also add a Note about "no Components.stack.caller"?
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #396023 - Flags: review?(rcampbell)
No longer blocks: 503623
Depends on: 355430
Comment on attachment 396023 [details] [diff] [review] (Av1) Do (the little) that can be done I'd like to see fctIdent unabbreviated. Maybe use functionId or funcIdentifier instead of fctIdent. Since we're not running mochitests on Opera (afaik), I don't think we need to use the || stacktrace || null check for errorStack. Remove the declaration for errorStack and just check for e.stack directly. Not very keen on the wording in the stack message. Maybe change it to just "JavaScript error stack:".
Attachment #396023 - Flags: review?(rcampbell) → review-
Av1, with comment 2 suggestion(s).
Attachment #396023 - Attachment is obsolete: true
Attachment #396100 - Flags: review?
Attachment #396100 - Flags: review? → review?(rcampbell)
Comment on attachment 396100 [details] [diff] [review] (Av2) Do (the little) that can be done [Checkin: Comment 6 & 8 & 11] thanks for the update!
Attachment #396100 - Flags: review?(rcampbell) → review+
forgot to respond to your question in comment 1: (In reply to comment #1) > Should I update MDC? yes, definitely. > Should I also add a Note about "no Components.stack.caller"? You can if you like. :)
Comment on attachment 396100 [details] [diff] [review] (Av2) Do (the little) that can be done [Checkin: Comment 6 & 8 & 11] http://hg.mozilla.org/mozilla-central/rev/d417a85ce9f7
Attachment #396100 - Attachment description: (Av2) Do (the little) that can be done → (Av2) Do (the little) that can be done [Checkin: Comment 6]
I thought about these while updating MDC ;->
Attachment #396147 - Flags: review?(rcampbell)
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [c-n: Av2 to m-1.9.2]
Target Milestone: --- → mozilla1.9.3a1
Comment on attachment 396100 [details] [diff] [review] (Av2) Do (the little) that can be done [Checkin: Comment 6 & 8 & 11] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/92ed133830cf
Attachment #396100 - Attachment description: (Av2) Do (the little) that can be done [Checkin: Comment 6] → (Av2) Do (the little) that can be done [Checkin: Comment 6 & 8]
Attachment #396147 - Flags: review?(rcampbell) → review+
Attachment #396147 - Attachment description: (Bv1) additional nits → (Bv1) additional nits [Checkin: Comment 9]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [c-n: Av2 to m-1.9.2] → [c-n: Av2 and Bv1 to m-1.9.2]
Comment on attachment 396147 [details] [diff] [review] (Bv1) additional nits [Checkin: Comment 9 & 10 & 12] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/78efe6c4810a
Attachment #396147 - Attachment description: (Bv1) additional nits [Checkin: Comment 9] → (Bv1) additional nits [Checkin: Comment 9 & 10]
Whiteboard: [c-n: Av2 and Bv1 to m-1.9.2] → [c-n: Av2 and Bv1 to m-1.9.2] [fixed1.9.1.4]
Comment on attachment 396100 [details] [diff] [review] (Av2) Do (the little) that can be done [Checkin: Comment 6 & 8 & 11] http://hg.mozilla.org/releases/mozilla-1.9.2/rev/4335f68f47bd
Attachment #396100 - Attachment description: (Av2) Do (the little) that can be done [Checkin: Comment 6 & 8] → (Av2) Do (the little) that can be done [Checkin: Comment 6 & 8 & 11]
Comment on attachment 396147 [details] [diff] [review] (Bv1) additional nits [Checkin: Comment 9 & 10 & 12] http://hg.mozilla.org/releases/mozilla-1.9.2/rev/46d711eded93
Attachment #396147 - Attachment description: (Bv1) additional nits [Checkin: Comment 9 & 10] → (Bv1) additional nits [Checkin: Comment 9 & 10 & 12]
Keywords: checkin-needed
Whiteboard: [c-n: Av2 and Bv1 to m-1.9.2] [fixed1.9.1.4] → [fixed1.9.2b1 fixed1.9.1.4]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: