Closed
Bug 512908
Opened 15 years ago
Closed 15 years ago
Don't expose empty live attribute if there is no aria-live and ARIA role hasn't default live value
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | beta1-fixed |
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug)
Details
(Keywords: access, regression, verified1.9.2)
Attachments
(1 file)
|
(deleted),
patch
|
MarcoZ
:
review+
davidb
:
review+
benjamin
:
approval1.9.2+
|
Details | Diff | Splinter Review |
Don't expose empty live attribute if there is no aria-live and ARIA role hasn't default live value
Attachment #396972 -
Flags: review?(marco.zehe)
Attachment #396972 -
Flags: review?(bolterbugz)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 396972 [details] [diff] [review]
patch
Thanks! r=me
Attachment #396972 -
Flags: review?(marco.zehe) → review+
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 396972 [details] [diff] [review]
patch
Oops, forgot tow nits:
>+ // Check if all obtained attributes are expected and has expected value.
"... and have expected value"
>+ // Check if all unexpected attribute are absent.
"Check if all unexpected attributes are absent", attributes must be plural here.
|
Assignee | |
Comment 3•15 years ago
|
||
thanks, fixed locally
|
||
Comment 4•15 years ago
|
||
Comment on attachment 396972 [details] [diff] [review]
patch
r=me
Attachment #396972 -
Flags: review?(bolterbugz) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/b1e0a654f2bf
Blocks: 463645
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Keywords: regression
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Attachment #396972 -
Flags: approval1.9.2?
|
||
Updated•15 years ago
|
Attachment #396972 -
Flags: approval1.9.2? → approval1.9.2+
|
|
Assignee | |
Comment 6•15 years ago
|
||
landed on 1.9.2 - http://hg.mozilla.org/releases/mozilla-1.9.2/rev/56243bdc4885
|
|
Assignee | |
Updated•15 years ago
|
status1.9.2:
--- → beta1-fixed
|
|
||
Comment 7•15 years ago
|
||
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1pre) Gecko/20090922 Namoroka/3.6b1pre (.NET CLR 3.5.30729)
Keywords: verified1.9.2
You need to log in
before you can comment on or make changes to this bug.
Description
•