Closed
Bug 513032
Opened 15 years ago
Closed 15 years ago
Remove empty conditionals in our makefiles
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
After removing REQUIRES there were a bunch of conditional blocks that were empty. So I wrote a script which detects and tries to remove empty makefile conditionals. It's not foolproof and required some manual intervention, so I'm going to post the patch and request review on it.
Attachment #397056 -
Flags: review?(ted.mielczarek)
Updated•15 years ago
|
Comment 1•15 years ago
|
||
Comment on attachment 397056 [details] [diff] [review]
Remove empty makefile conditionals, rev. 1
You've got a few more random pymake changes here. Did you mean to include those? (Also remember you landed a few random ones in the original REQUIRES cleanup.)
--- a/gfx/cairo/libpixman/src/Makefile.in
-ifdef HAVE_ARM_NEON
-# temporarily disabled to see if it fixes odd mobile build breakage
-#USE_ARM_NEON_GCC=1
-endif
Feels like we shouldn't just remove this, bug I also hate having stuff commented out living on forever.
Looks fine otherwise.
Attachment #397056 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 2•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 3•14 years ago
|
||
Ben, do you have the script you used to purge the empty conditionals still, the only script I saw around in a bug is the "Remove REQUIRES" one.
Assignee | ||
Comment 4•14 years ago
|
||
No, I can't find it.
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•