Closed Bug 513275 Opened 15 years ago Closed 15 years ago

New bookmark folders show "(Empty)" item until SeaMonkey restarted, take 2

Categories

(SeaMonkey :: Bookmarks & History, defect)

x86
Windows 2000
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED
seamonkey2.0

People

(Reporter: sgautherie, Assigned: neil)

References

Details

(Keywords: fixed-seamonkey2.0, polish, regression)

Attachments

(1 file)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1.1pre) Gecko/20090717 SeaMonkey/2.0b1] (release) (W2Ksp4) [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a1pre) Gecko/20090819 SeaMonkey/2.1a1pre] (home, optim default) (W2Ksp4) (http://hg.mozilla.org/mozilla-central/rev/aef07655f47f +http://hg.mozilla.org/comm-central/rev/140d79e50cc7 + bug 510717 patch A) 1. Create a new folder. (Any way you like.) 2. Drag and drop from the location bar to the new folder. (Drop on folder name, '(Empty)' is not dropppable :-/) 3. Reopen folder. 3r. Both '(Empty)' and the bookmark are there :-( Workaround: 4. Open Bookmark Manager. 4r. Check that B.M. doesn't show '(Empty)', only the P.T. does. 5. Move the folder. 5r. P.T. doesn't display '(Empty)' anymore. I assume this is a regression, as bug 79411 was R.Fixed.
Flags: wanted-seamonkey2?
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070515 SeaMonkey/1.5a] (nightly) (W2Ksp4) SM 1.5a had bug 262231 but not this one.
When dropping on '(Empty)', I get the following in the error console: Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFService.GetResource]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: chrome://communicator/content/bookmarks/bookmarksMenu.js :: anonymous :: line 129" data: no] Not sure if that's something else or related to this.
(In reply to comment #2) > When dropping on '(Empty)', I get the following in the error console: Ah, thanks for noticing! I confirm with both 2.0b1 and lastest 2.0b2 nightly. > Not sure if that's something else or related to this. I would guess it is related, as in possibly the cause.
(In reply to comment #1) > SM 1.5a had bug 262231 but not this one. [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/2007052914 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) Too.
New behavior appeared between [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20081202 SeaMonkey/2.0a2] (release) (W2Ksp4) and [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20090223 SeaMonkey/2.0a3] (release) (W2Ksp4)
New behavior appeared between [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20081213 SeaMonkey/2.0a3pre] (nightly) (W2Ksp4) and [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20081214 SeaMonkey/2.0a3pre] (nightly) (W2Ksp4) http://hg.mozilla.org/comm-central/pushloghtml?startdate=2008-12-12+23&enddate=2008-12-14+01 Most probably bug 461167.
Blocks: 461167
Flags: wanted-seamonkey2.0? → wanted-seamonkey2.0+
(In reply to comment #6) > Most probably bug 461167. Yeah, well if you back that out you don't get any "(Empty)" items at all...
Yeah, I didn't mean to back it out: just finding out where/what to look at.
Attached patch Proposed patch (deleted) — Splinter Review
Using CSS instead as isempty doesn't seem to be reliable in a template.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #401425 - Flags: review?(iann_bugzilla)
(In reply to comment #2) > When dropping on '(Empty)', I get the following in the error console: > > Error: uncaught exception: [Exception... "Component returned failure code: > 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFService.GetResource]" nsresult: > "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: > chrome://communicator/content/bookmarks/bookmarksMenu.js :: anonymous :: line > 129" data: no] > > Not sure if that's something else or related to this. That isn't fixed by the current patch on this bug.
Attachment #401425 - Flags: review?(iann_bugzilla)
Attachment #401425 - Flags: review+
Attachment #401425 - Flags: approval-seamonkey2.0+
No, that's a separate bug.
[Note to fixer of drop bug: drop on (Empty) should work like drop on parent.]
Pushed changeset 0dc6f51f3cc3 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a1pre) Gecko/20090921 SeaMonkey/2.1a1pre] (nightly) (W2Ksp4) V.Fixed (In reply to comment #2) > When dropping on '(Empty)', I get the following in the error console: I filed bug 518060.
Status: RESOLVED → VERIFIED
Target Milestone: --- → seamonkey2.0
Depends on: 525926
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: