Neil Deakin Assignee
	Description • 15 years ago

Allow the fix for bug 487817 to be used for other tests as well. This patch adds a method to wait for both a load and focus method before calling a callback:

SimpleTest.waitForFocus(callback, targetWindow)

targetWindow defaults to 'window'.

	Neil Deakin Assignee
	Comment 1 • 15 years ago

http://hg.mozilla.org/mozilla-central/rev/80b92799c562

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 2 • 15 years ago

Did this regress Bug 513707?

	Neil Deakin Assignee
	Comment 3 • 15 years ago

A couple of days ago I checked in an improvement to this function which handles the case where the window is already focused and/or loaded, as well as added some logging information. I haven't seen any focus related failures on these tests since.

	Serge Gautherie (:sgautherie)
	Comment 4 • 15 years ago

Neil, could you land all that is needed on the branches?

	Marco Bonardo [:mak]
	Comment 5 • 15 years ago

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9f66d32950bf
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/7915c3bcf85d

notice i also had to push:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/838b26c49605
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/44800e329810

that brought improvements to the method. I think all of these are needed on 1.9.1, but i'm not sure if 1.9.1 can take all of this (focus rewrite went after 1.9.1 iirc)

	Serge Gautherie (:sgautherie)
	Comment 6 • 12 years ago

(In reply to Marco Bonardo [:mak] from comment #5)
> http://hg.mozilla.org/releases/mozilla-1.9.2/rev/7915c3bcf85d

Ftr, this changeset was part of bug 554873.

	Serge Gautherie (:sgautherie)
	Comment 7 • 12 years ago

(In reply to Serge Gautherie (:sgautherie) from comment #6)
> (In reply to Marco Bonardo [:mak] from comment #5)
> > http://hg.mozilla.org/releases/mozilla-1.9.2/rev/7915c3bcf85d
> 
> Ftr, this changeset was part of bug 554873.

Wrong.
This m-1.9.2 changeset had landed as
http://hg.mozilla.org/mozilla-central/rev/bad2d2351f7f
in "m-1.9.3/m-2.0".