Closed
Bug 513741
Opened 15 years ago
Closed 15 years ago
"ASSERTION: rule walker must be at root" with XBL, rem unit, display:table
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: jruderman, Unassigned)
References
Details
(Keywords: assertion, testcase)
Attachments
(3 files)
###!!! ASSERTION: rule walker must be at root: 'mRuleWalker->AtRoot()', file /Users/jruderman/central/layout/style/nsStyleSet.cpp, line 691
This assertion was added in bug 507457 comment 10.
|
||
Comment 1•15 years ago
|
||
I'm not sure what we ought to do about this.
We could just make GetContext reset the rule walker before calling NS_NewStyleContext.
Or we could make the rule walker not be a member of the style set at all; that would either change the bug 492675 / bug 466024 crashes into something else or fix them.
I'm sort of tempted to just do the latter; I was tempted to do it when fixing bug 507457.
Thoughts?
|
|
||
Comment 2•15 years ago
|
||
Here's the simple patch.
It's possible this also fixes bug 466024.
I also threw in a signed-vs.-unsigned-comparison warning fix.
Attachment #403320 -
Flags: review?(bzbarsky)
|
||
Updated•15 years ago
|
Attachment #403320 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 3•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
|
|
||
Comment 4•15 years ago
|
||
(In reply to comment #2)
> It's possible this also fixes bug 466024.
... and bug 492675; they're really the same thing, and I forget to mention both sometimes.
|
|
||
Comment 5•15 years ago
|
||
Actually, I take that back; I don't think this will fix a crash in FileRules or AddImportantRules.
You need to log in
before you can comment on or make changes to this bug.
Description
•