Closed
Bug 514131
Opened 15 years ago
Closed 15 years ago
Kill xpcom/obsolete
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: Mitch, Assigned: Mitch)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
application/octet-stream
|
Details |
It's obsolete and should go away.
This patch is an attempt to make it go away.
Attachment #398088 -
Flags: review?(benjamin)
|
Assignee | |
Comment 1•15 years ago
|
||
This actually builds.
Attachment #398088 -
Attachment is obsolete: true
Attachment #398089 -
Flags: review?(benjamin)
Attachment #398088 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 2•15 years ago
|
||
This is a bundle of the previous changes.
|
|
Assignee | |
Updated•15 years ago
|
Attachment #398122 -
Attachment is patch: false
|
||
Updated•15 years ago
|
Attachment #398122 -
Attachment mime type: text/plain → application/octet-stream
|
|
||
Updated•15 years ago
|
Attachment #398089 -
Flags: review?(benjamin) → review+
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 398089 [details] [diff] [review]
Patch v1.1
Awesome.
Please file a followup bug about removing the nsIPref API which is no longer supported (Get/SetFilePref)
|
|
||
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → Trunk
|
||
Comment 6•15 years ago
|
||
(In reply to comment #3)
> (From update of attachment 398089 [details] [diff] [review])
> Awesome.
>
> Please file a followup bug about removing the nsIPref API which is no longer
> supported (Get/SetFilePref)
It is filed as bug 214796.
|
||
Updated•15 years ago
|
Flags: in-testsuite-
|
|
||
Comment 7•15 years ago
|
||
Comment on attachment 398089 [details] [diff] [review]
Patch v1.1
>diff --git a/configure.in b/configure.in
>-if test -n "$MOZ_NO_XPCOM_OBSOLETE" && test `echo "$MOZ_EXTENSIONS" | grep -c sroaming` -ne 0; then
>- AC_MSG_WARN([Cannot currently build sroaming without xpcom obsolete -- bug 249343. Removing sroaming from MOZ_EXTENSIONS.])
>- MOZ_EXTENSIONS=`echo $MOZ_EXTENSIONS | sed -e 's|sroaming||'`
>-fi
Bug 249343 is not fixed. Why remove this code?
You need to log in
before you can comment on or make changes to this bug.
Description
•