Jason Orendorff [:jorendorff] Reporter
	Description • 15 years ago

Follow-up to bug 471214 comment 117:
> This is obvious in hindsight. XBL has JS-implemented methods, they are null
> closures defined in object initialisers. One such is QueryInterface on the
> _observer field in findbar.xml. Alas XPConnect wants to QI, so it digs out the
> value using JS_GetPropertyById, which runs the method barrier.

This is in nsXPCWrappedJSClass::CallQueryInterfaceOnJSObject.

Hard to tell if exposing something like js_TryMethod would be enough or if we really need JS_UnsafeGetRawMethodById.

	Brendan Eich [:brendan]
	Comment 1 • 15 years ago

Don't forget to fix nsXPCWrappedJSClass::CallMethod, which calls JS_GetMethod. Anything else like these?

Wait, who will take this bug? I will if no one else, but could use help. mrbkap would be best :-).

/be

	Brendan Eich [:brendan]
	Comment 2 • 15 years ago

js_TryMethod suppresses some exceptions and isn't the right tool. Just js_GetMethod as a FRIEND API would do for a minimal fix.

/be

	David Mandelin [:dmandelin]
	Comment 3 • 13 years ago

Obviated by bug 739808.