Closed
Bug 514976
Opened 15 years ago
Closed 15 years ago
Inline mailSessionContractID string/value
Categories
(MailNews Core :: Search, defect)
MailNews Core
Search
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.1b1
People
(Reporter: sgautherie, Assigned: wesongathedeveloper)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
standard8
:
superreview+
|
Details | Diff | Splinter Review |
While there do it for SM and TB too.
These const/var seem superfluous...
|
Reporter | |
Updated•15 years ago
|
Whiteboard: [good first bug]
|
||
Comment 1•15 years ago
|
||
let's get this off unconfirmed
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
Assignee | |
Comment 2•15 years ago
|
||
Assignee: nobody → wesongathedeveloper
Status: NEW → ASSIGNED
Attachment #416290 -
Flags: review?(neil)
|
|
Reporter | |
Comment 3•15 years ago
|
||
Comment on attachment 416290 [details] [diff] [review]
Patch
>+var gMailSession = Components.classes["@mozilla.org/messenger/services/session;1"]
> .getService(nsIMsgMailSession);
Nit: could you align them all like this one? Thanks.
Attachment #416290 -
Flags: superreview?(bugzilla)
|
||
Updated•15 years ago
|
Attachment #416290 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
|
|
Reporter | |
Updated•15 years ago
|
Attachment #417300 -
Flags: superreview?(bugzilla)
|
|
Reporter | |
Updated•15 years ago
|
Attachment #416290 -
Attachment is obsolete: true
Attachment #416290 -
Flags: superreview?(bugzilla)
|
||
Comment 5•15 years ago
|
||
Comment on attachment 417300 [details] [diff] [review]
Patch with nit fixed
[Checkin: Comment 6]
Sorry for the delay in getting to this. sr=Standard8
Attachment #417300 -
Flags: superreview?(bugzilla) → superreview+
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 6•15 years ago
|
||
Comment on attachment 417300 [details] [diff] [review]
Patch with nit fixed
[Checkin: Comment 6]
http://hg.mozilla.org/comm-central/rev/5b4b0fcd3b6d
Attachment #417300 -
Attachment description: Patch with nit fixed → Patch with nit fixed
[Checkin: Comment 6]
|
|
Reporter | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [good first bug]
|
|
Reporter | |
Updated•15 years ago
|
Target Milestone: --- → Thunderbird 3.1b1
You need to log in
before you can comment on or make changes to this bug.
Description
•