Closed
Bug 516629
Opened 15 years ago
Closed 15 years ago
[OS/2] Build break in accessible
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta2-fixed |
People
(Reporter: dave.r.yeo, Assigned: dave.r.yeo)
References
Details
Attachments
(1 file)
(deleted),
patch
|
surkov
:
review+
beltzner
:
approval1.9.2+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.1.3pre) Gecko/20090823 SeaMonkey/2.0b2pre
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.3a1pre) Gecko/20090914 Minefield/3.7a1pre
Check in http://hg.mozilla.org/mozilla-central/rev/37b976412c04 from bug #512424 has a transposed variable name in /accessible/src/other/nsHTMLTableAccessibleWrap.h which breaks the build on OS/2
Reproducible: Always
Steps to Reproduce:
1.Attempt to build trunk
2.
3.
Actual Results:
Build breaks with errors
Expected Results:
A working browser
Fix transposed variable name. Thanks to Rich Walsh for finding it.
Comment 2•15 years ago
|
||
Comment on attachment 400651 [details] [diff] [review]
Correct transposed variable name
r=me, thank you for the patch
Attachment #400651 -
Flags: review+
Updated•15 years ago
|
Assignee: nobody → daveryeo
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment 4•15 years ago
|
||
Sure once I catch green tree then I'll check in this.
Comment 5•15 years ago
|
||
landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/2448a0d9f35c
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Attachment #400651 -
Flags: approval1.9.2?
Comment 6•15 years ago
|
||
Comment on attachment 400651 [details] [diff] [review]
Correct transposed variable name
Once bug 512424 is approved and landed, this needs to land along with it as an OS/2 build bustage fix. See https://wiki.mozilla.org/Accessibility/Remaining_Mozilla-1.9.2_Nominations for more info.
Comment 7•15 years ago
|
||
Comment on attachment 400651 [details] [diff] [review]
Correct transposed variable name
a192=beltzner
Attachment #400651 -
Flags: approval1.9.2? → approval1.9.2+
Comment 8•15 years ago
|
||
landed on 1.9.2 - http://hg.mozilla.org/releases/mozilla-1.9.2/rev/0e3caf47df9e
Comment 9•15 years ago
|
||
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b2pre) Gecko/20091029 Namoroka/3.6b2pre (.NET CLR 3.5.30729)
status1.9.2:
--- → final-fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•