Closed
Bug 516641
Opened 15 years ago
Closed 15 years ago
Create better theme for web content form controls
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(fennec1.1+)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fennec | 1.1+ | --- |
People
(Reporter: mfinkle, Assigned: vingtetun)
References
Details
(Whiteboard: [polish])
Attachments
(2 files, 7 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
The current non-native theme looks poor. We need to add styling for:
* textbox / textarea
* button
* combobox (select size=1)
* listbox (select size>1)
* radio (?)
* checkboxes (?)
Reporter | ||
Updated•15 years ago
|
tracking-fennec: --- → ?
Updated•15 years ago
|
Assignee: nobody → madhava
Whiteboard: [polish]
Updated•15 years ago
|
tracking-fennec: ? → 1.0+
Comment 1•15 years ago
|
||
Two questions --
1. Are we interested in having "system native" in-content controls, as we try to on desktop platforms? Here is what controls look like in "Web" on the n900:
http://www.flickr.com/photos/madhava_work/3966664815/sizes/o/
2. If we want to create something else, do we have similar constraints, performance-wise, as with creating buttons we use in chrome? In other words, should we be sticking to border image?
Reporter | ||
Comment 2•15 years ago
|
||
We do not want to mimic the microb ("Web") look for web form controls. We want something with a bit nicer. I personally like the look of the Linux desktop Firefox widgets or even the Windows Vista look.
We should try to make things as fast as possible. We are currently using the non-native theme for web form controls. This theme uses "border-color" and "border: inset and outset" for border styling. I don't think we want "border-image" unless we have a very hard time achieving our goals _or_ we show no performance/rendering issues.
Reporter | ||
Comment 3•15 years ago
|
||
Yeah, I know "border-image" would allow for some kick-ass theme options
Comment 4•15 years ago
|
||
Sean's working page:
http://mozilla.seanmartell.com/fennec/forms/
Updated•15 years ago
|
tracking-fennec: 1.0+ → 1.0-
Assignee | ||
Comment 5•15 years ago
|
||
This wip has some problems with:
* radio buttons, the "dark circle" of the radio button is not centered on some pages (e.g: http://google.com)
* buttons: The rendering is squarred on some sites (e.g: http://people.mozilla.com/~mfinkle/select.html)
Assignee | ||
Comment 6•15 years ago
|
||
This wip add:
* skin for all forms elements
* as closed as possible to sean's working page
* work on the previously mentionned select.html page
This wip missed:
* some skin for disabled elements
* some few bugs with the radio buttons when looking at internet
* using images for internal of radio, checkbox, select
For the bug on radio button on google.fr I can already see it without this patch, it is just more obvious with it.
Attachment #432571 -
Attachment is obsolete: true
Assignee | ||
Comment 7•15 years ago
|
||
This is pretty much like sean's mockup
Assignee | ||
Comment 8•15 years ago
|
||
Actually theming regress performance when we're calling Browser.setVisibleRect, I'm diving into that.
Attachment #432969 -
Attachment is obsolete: true
Assignee | ||
Comment 9•15 years ago
|
||
(In reply to comment #8)
> Created an attachment (id=433041) [details]
> wip-3
>
> Actually theming regress performance when we're calling Browser.setVisibleRect,
> I'm diving into that.
To avoid this performance regression we should not not:
* use different border colors for side, this mean we could use -moz-border-[tlbr]-colors: #aaaaa #bbbbb but the borders for each side should be the same
* avoid combining -moz-border-[tlbr]-colors AND -moz-border-radius, these can be safely otherwise
This happen because if we know how exactly how to render the border it could be some optimization which is called here:
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsCSSRenderingBorders.cpp#1070
Assignee | ||
Comment 10•15 years ago
|
||
This new patch take into account the previous discovery and is in correlation with the new sean's mockup buttons style. Simple tests show that performance are not affected, but I will more tests to confirm that fact.
For an idea of how is it looking please see the next screenshot.
Feedback are welcome.
Assignee: madhava → 21
Attachment #433041 -
Attachment is obsolete: true
Assignee | ||
Comment 11•15 years ago
|
||
A few webpages with forms and how they look with the new theme
Attachment #432970 -
Attachment is obsolete: true
Assignee | ||
Comment 12•15 years ago
|
||
Sean,
I'm cc'ing because I want to keep in sync with you an have your feedback on where we are on this particular bug. A screenshot of what we can do without regressing performance is attached (I've seen your button's mockup)
Assignee | ||
Comment 13•15 years ago
|
||
This version correct some paddings mistakes I have in the previous patch.
Sean,
can we have your opinion on the look and feel of the previous screenshot? Thanks.
Attachment #433482 -
Attachment is obsolete: true
Updated•15 years ago
|
tracking-fennec: 1.0- → 1.1+
Assignee | ||
Comment 14•15 years ago
|
||
This patch implement sean's mockup style.
Attachment #434216 -
Attachment is obsolete: true
Attachment #435576 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 15•15 years ago
|
||
Replace % per pixels where it is needed
Attachment #435576 -
Attachment is obsolete: true
Attachment #435643 -
Flags: review?(mark.finkle)
Attachment #435576 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 16•15 years ago
|
||
Comment on attachment 435643 [details] [diff] [review]
Patch v0.3
Looks a lot better than our current theme _and_ very close to martell's proposal.
I think we will tweak some parts later and we need to be mindful of performance issues (pageload and zoom are possible issues)
Attachment #435643 -
Flags: review?(mark.finkle) → review+
Reporter | ||
Comment 17•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Flags: in-testsuite?
Comment 18•15 years ago
|
||
verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.3pre) Gecko/20100331 Namoroka/3.6.3pre Fennec/1.1a2pre
and
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.3a4pre) Gecko/20100331 Namoroka/3.7a4pre Fennec/1.1a2pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•