Mats Palmgren (inactive) Assignee
	Description • 15 years ago

Followup from bug 233463 comment 93:

Comment From  Boris Zbarsky:
> > nsBlockFrame::GetOverflowOutOfFlows() const
> >+  return nsFrameList(result, nsLayoutUtils::GetLastSibling(result));
Maybe file a followup bug to store the overflow out of flows as an nsFrameList,
unless we're guaranteed that there aren't many of them....  And maybe even
then.

	Mats Palmgren (inactive) Assignee
	Comment 1 • 15 years ago

First naive version.  I don't think saving/checking the old value
is necessary anymore though...  new patch coming with that...

	Boris Zbarsky [:bzbarsky]
	Comment 3 • 15 years ago

Comment on attachment 402109 [details] [diff] [review]
Patch rev. 1

>+++ b/layout/generic/nsBlockFrame.cpp
>+nsBlockFrame::SetOverflowOutOfFlows(const nsFrameList& aList,
>+  else {
>+    SetPropTableFrames(PresContext(), new nsFrameList(aList),
>+                       nsGkAtoms::overflowOutOfFlowsProperty);

This case could assert !aPropValue, right?  If so, please do.

r=bzbarsky

	Mats Palmgren (inactive) Assignee
	Comment 4 • 15 years ago

(In reply to comment #3)
> This case could assert !aPropValue, right?  If so, please do.

Yes, but the NS_PRECONDITION covers that.  And SetPropTableFrames()
asserts that the property doesn't already exist.

	Mats Palmgren (inactive) Assignee
	Comment 5 • 15 years ago

http://hg.mozilla.org/mozilla-central/rev/ab4cfe0e49ad