Closed
Bug 517091
Opened 15 years ago
Closed 15 years ago
Don't do an expensive asynchronous RequestDecode() if there's already an active full decoder
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bholley, Assigned: bholley)
Details
(Whiteboard: [decodeondraw])
Attachments
(1 file)
|
(deleted),
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
According to my local Tp4 runs, this seems to be the (or a major) source of the regression in bug 516331. Pushing to try in a moment to verify.
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [decodeondraw]
|
|
Assignee | |
Comment 1•15 years ago
|
||
added the patch. Pushed to try as ea0dc4e75f07, along with a patch to re-enable discarding so that we can see if this fixes the regression.
|
|
Assignee | |
Updated•15 years ago
|
Attachment #401129 -
Flags: review?(joe)
|
|
Assignee | |
Comment 2•15 years ago
|
||
Comment on attachment 401129 [details] [diff] [review]
patch v1
this seems to fix the problem on try. It's hard to get a decent baseline, but it looks like turning on discarding with this patch makes Tp4 go 660->690, which is to be expected given the perf hit involved with discarding in general (see bug 502694 and bug 517119).
flagging joe for review.
|
||
Comment 3•15 years ago
|
||
Comment on attachment 401129 [details] [diff] [review]
patch v1
Add to the "if we're within the decoder" comment something talking about being reentrant, for clarity.
Attachment #401129 -
Flags: review?(joe) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/54f161dc183a
resolving fixed.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•