Closed
Bug 517382
Opened 15 years ago
Closed 7 years ago
JSOP_INCNAME and its ilk seem to always miss prop cache when incrementing global in this testcase
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
INCOMPLETE
People
(Reporter: bzbarsky, Unassigned)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
(deleted),
text/html
|
Details |
STEPS TO REPRODUCE:
1) Breakpoint in the JSOP_INCNAME/DECNAME/etc case in jsops.cpp
2) Load attached testcase.
3) Step down to right after the ASSERT_VALID_PROPERTY_CACHE_HIT when trying
to increment |x|.
4) Observe that PCVAL_IS_SLOT(entry) is false.
5) See that we call js_FindPropertyHelper as a result.
6) Note that this happens every time we try to increment x.
I can understand not being able to take the fast-increment path if the entry is not a slot (though not why it's not a slot in this case, honestly). But do we really have to call js_FindPropertyHelper?
|
Reporter | |
Comment 1•15 years ago
|
||
|
Assignee | |
Updated•10 years ago
|
Assignee: general → nobody
|
||
Comment 2•7 years ago
|
||
JSOP_INCNAME is no longer present, therefore closing this bug as INCOMPLETE.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•