Closed
Bug 517895
Opened 15 years ago
Closed 15 years ago
columns reftests are fragile w.r.t. font metrics
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jfkthame, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Several of the reftests in columns will break if the default font is changed to something like Charis SIL, which has unusually large ascent/descent metrics (because it supports stacking diacritics), and/or the default font size is significantly increased (e.g., run reftest with font size 32 instead of 16).
Ideally, the reftests would be independent of such font settings.
Specific tests where I ran into such failures are:
column-balancing-004
columnrule-basic
columnrule-complex
columnrule-padding
The attached patch makes the reftests more robust, by a combination of explicit font size control and/or increasing dimensions to allow for fonts with greater ascent/descent. Sufficiently bizarre fonts might still cause problems, but this makes them much more reliable in local testing here.
Attachment #401855 -
Flags: review?(roc)
Attachment #401855 -
Flags: review?(roc) → review+
Reporter | ||
Comment 1•15 years ago
|
||
pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/4a0dfd134a38
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•