Closed
Bug 518549
Opened 15 years ago
Closed 13 years ago
Consider treating switch specially for MAX_BRANCHES purposes
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: bzbarsky, Unassigned)
References
Details
We have MAX_BRANCHES to deal with trace explosion, but for a switch compiling a number of traces equal to the number of cases (which can easily be more than 32) is the expected and desired behavior, right? I think we should consider not counting switch "branches" in MAX_BRANCHES, at least once bug 516264 is fixed for switches.
Comment 1•15 years ago
|
||
We already do that. From jstracer.cpp:
if (anchor && anchor->exitType != CASE_EXIT)
++treeInfo->branchCount;
Reporter | ||
Comment 2•15 years ago
|
||
Ah, ok. Sounds like this bug is invalid then?
Comment 3•15 years ago
|
||
Mostly. But even if the main split point is exempt, the overall tree still hits the limit quickly if the cases are not trivial and branch themselves.
Comment 4•13 years ago
|
||
Obsolete with the removal of tracejit.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•