Chris Jones [:cjones] inactive; ni?/f?/r? if you need me Assignee
	Description • 15 years ago

(Platform/OS should really read "any on which we use a compiler supporting a warn_unused_result-type attribute".)

In Electrolysis, we call functions that end up sending IPC messages to other processes.  *Any* invocation of these functions may fail, since the other process may die completely unpredictably.  I'm sure there are other functions like this in mozilla-central (networking comes to mind).

So we want to ensure that the return value from such functions is always checked.  gcc's __attribute__((warn_unused_result)) is a start, and -Werror=warn_unused_result (or whatever it is) is even better.  A static analysis that makes warn_unused_result a transitive property is best of all.

	Chris Jones [:cjones] inactive; ni?/f?/r? if you need me Assignee
	Comment 1 • 15 years ago

Not tryserver'ing because this is just code taken from bug 441324.

	Chris Jones [:cjones] inactive; ni?/f?/r? if you need me Assignee
	Comment 2 • 15 years ago

Infallible malloc is about ready to land, and that patch incidentally adds this attribute.  (RESOLVED SUBSUMED would be more appropriate.)