Closed
Bug 519186
Opened 15 years ago
Closed 15 years ago
drag & drop in bookmarks menu does not correctly update the view
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 3.7a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta1-fixed |
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: regression, verified1.9.2)
Attachments
(1 file)
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
This is most likely regression from bug 498130
1. create a new profile
2. open bookmarks menu
3. drag "Get bookmarks add-ons" below the next separator
result:
4. item moves to a "random" position
expected:
4. correct position for drop
Assignee | ||
Comment 1•15 years ago
|
||
sounds like it is not taking in count the _startMarker
Assignee | ||
Comment 2•15 years ago
|
||
indeed in nodeMoved popup.insertBefore(nodeElt, popup.childNodes[aNewIndex]);
should most likely do the same as nodeInserted
let index = popup._startMarker + 1 + aIndex;
Comment 3•15 years ago
|
||
marco: I cannnot test this, but I'll gladly review ;)
Assignee | ||
Comment 5•15 years ago
|
||
Attachment #403484 -
Flags: review?(mano)
Updated•15 years ago
|
Attachment #403484 -
Flags: review?(mano) → review+
Comment 6•15 years ago
|
||
Comment on attachment 403484 [details] [diff] [review]
patch v1.0
r=mano. Thanks Marco!
Assignee | ||
Comment 8•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Assignee | ||
Comment 9•15 years ago
|
||
the patch has been merged by Mano in 1.9.2 landing for bug 498130. so this is fixed on that branch too.
status1.9.2:
--- → beta1-fixed
Comment 10•15 years ago
|
||
Verified fix on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1pre) Gecko/20091009 Namoroka/3.6b1pre
and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091009 Namoroka/3.7a1pre
Status: RESOLVED → VERIFIED
Keywords: verified1.9.2
Updated•14 years ago
|
Flags: in-testsuite?
Flags: in-litmus?
Updated•13 years ago
|
Flags: in-testsuite?
Flags: in-litmus?
You need to log in
before you can comment on or make changes to this bug.
Description
•