Closed
Bug 519769
Opened 15 years ago
Closed 14 years ago
Open shared/unshared connections with options instead of setting shared state always
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla2.0b5
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
As of SQLite 3.6.18, we can use two constants to open with the shared cache or without. This means we can stop enabling/disabling the shared cache like we currently do. Constants to use: SQLITE_OPEN_SHAREDCACHE SQLITE_OPEN_PRIVATECACHE
|
Assignee | |
Updated•15 years ago
|
Depends on: SQLite3.6.20
|
|
Assignee | |
Comment 1•14 years ago
|
||
This is OK for NSS too because they only use one connection so they never depended on us having the shared cache turned on.
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs review asuth]
|
||
Updated•14 years ago
|
Attachment #462216 -
Flags: review?(bugmail) → review+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs review asuth] → [needs approval]
|
|
Assignee | |
Updated•14 years ago
|
Attachment #462216 -
Flags: approval2.0?
|
|
Assignee | |
Comment 3•14 years ago
|
||
I don't really think there is much risk here. We are doing the same thing that the SQLite API was doing, but now without acquiring a mutex (so less contention). Also, simpler code.
|
||
Updated•14 years ago
|
Attachment #462216 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs approval] → [can land]
|
|
Assignee | |
Comment 4•14 years ago
|
||
With proper commit message
Attachment #462216 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: dev-doc-needed
|
|
Assignee | |
Updated•14 years ago
|
Keywords: dev-doc-needed
|
|
Assignee | |
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/88be5af389ed
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [can land]
Target Milestone: --- → mozilla2.0b5
You need to log in
before you can comment on or make changes to this bug.
Description
•