Closed
Bug 519927
Opened 15 years ago
Closed 15 years ago
Add .htaccess rules for new in-product help link "keyboard-shortcuts"
Categories
(support.mozilla.org :: General, defect)
support.mozilla.org
General
Tracking
(Not tracked)
VERIFIED
FIXED
1.5.4
People
(Reporter: ehsan.akhgari, Assigned: paulc)
References
()
Details
(Whiteboard: 1.5.4+)
Attachments
(1 file)
(deleted),
patch
|
jsocol
:
review+
|
Details | Diff | Splinter Review |
With bug 513168, we'll get a new product help link from Firefox (http://support.mozilla.com/1/%APP%/%VERSION%/%OS%/%LOCALE%/keyboard-shortcuts) that needs to be directed to the following article.
http://support.mozilla.com/kb/Keyboard+shortcuts?style_mode=inproduct
Comment 1•15 years ago
|
||
Is this for Firefox 3.6?
3.7 per the bug but also for nightly users as soon as that patch lands.
Assignee | ||
Comment 3•15 years ago
|
||
I'll take it. When should this end up on prod?
Assignee: nobody → paulc
Comment 5•15 years ago
|
||
Nominating for 1.5.4. We've already got the plugin-crash help-topic done for 3.7; and this should also be done before 3.7.
Whiteboard: 1.5.4?
Assignee | ||
Comment 7•15 years ago
|
||
This works even if there will be a separate URL for EU-ballot builds. If anyone knows that's not the case, please say so.
Attachment #440905 -
Flags: review?(james)
Updated•15 years ago
|
Flags: in-testsuite?
Updated•15 years ago
|
Attachment #440905 -
Flags: review?(james) → review+
Comment 8•15 years ago
|
||
Comment on attachment 440905 [details] [diff] [review]
v1, adds rewrite for regular and eu-ballot URLs
WFM. Couple things to note for future:
* EU ballot builds have a different baseURL. We always need to be sure anything that works for one works for the other. (Perhaps at some point we could put (?:/eu)? in the main rule, instead of doubling?)
* I don't thing bug 513168 has even landed yet. But we'll be ready!
Assignee | ||
Comment 9•15 years ago
|
||
(In reply to comment #8)
> (From update of attachment 440905 [details] [diff] [review])
> WFM. Couple things to note for future:
>
> * EU ballot builds have a different baseURL. We always need to be sure anything
> that works for one works for the other. (Perhaps at some point we could put
> (?:/eu)? in the main rule, instead of doubling?)
Next time we touch this file, would be nice to do that. Good point.
Assignee | ||
Comment 10•15 years ago
|
||
r66349
QA: test URLs look like:
http://support-stage.mozilla.com/1/firefox/3.6.4/Darwin/en-US/firefox-help
http://support-stage.mozilla.com/1/firefox/3.6.4/Darwin/en-US/eu/firefox-help
Should this be on the fennec branch as well, or is it just a desktop feature?
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 11•15 years ago
|
||
(In reply to comment #10)
> r66349
>
> QA: test URLs look like:
> http://support-stage.mozilla.com/1/firefox/3.6.4/Darwin/en-US/firefox-help
> http://support-stage.mozilla.com/1/firefox/3.6.4/Darwin/en-US/eu/firefox-help
>
> Should this be on the fennec branch as well, or is it just a desktop feature?
Keyboard shortcuts? Pretty sure it's desktop.
Comment 13•15 years ago
|
||
Updated the redirect automation script for /keyboard-shortcuts redirects
http://viewvc.svn.mozilla.org/vc/projects/sumo/tests/frontend/php_tests/test_TC_rewrites.php
Flags: in-testsuite? → in-testsuite+
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•