Closed
Bug 520161
Opened 15 years ago
Closed 15 years ago
TM: Duplicate property in object literal causes "Assertion failure: !scope->has(sprop)"
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla1.9.2
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | beta3-fixed |
People
(Reporter: jruderman, Assigned: brendan)
References
Details
(Keywords: assertion, regression, testcase, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
(deleted),
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
for (var j = 0; j < 3; ++j) { ({x:0, x:0}); }
Assertion failure: !scope->has(sprop), at ../jsbuiltins.cpp:276
|
||
Comment 1•15 years ago
|
||
autoBisect shows this is probably related to bug 518448:
The first bad revision is:
changeset: 33273:b0d906da856a
user: Brendan Eich
date: Tue Sep 29 19:05:19 2009 -0700
summary: High-level CSE for shape guards (518448, r=jorendorff).
Nominating wanted-1.9.2 since bug 518448 is also nominated wanted-1.9.2...
|
Assignee | |
Comment 2•15 years ago
|
||
An ES5 strict mode error. Just getting people ready... :-P
/be
Assignee: general → brendan
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.2
|
|
Assignee | |
Comment 3•15 years ago
|
||
Unfortunate to add a lookup (search) when JSScope::add does a search right away. We could propagate added down as an out param to add. But is doing this premature optimization? I don't have low-noise perf-testing hardware, so I may roll the talos dice...
/be
Attachment #404298 -
Flags: review?(jorendorff)
|
||
Updated•15 years ago
|
Attachment #404298 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Updated•15 years ago
|
Flags: in-testsuite?
|
||
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•15 years ago
|
||
status1.9.2:
--- → final-fixed
Flags: wanted1.9.2? → wanted1.9.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•