Closed Bug 520319 Opened 15 years ago Closed 15 years ago

Adding a new credit card on amazon fails -- complains that the expiration date is wrong

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: davida, Assigned: brendan)

References

(
URL
)

Details

(Keywords: regression)

Attachments

(1 file)

screenshot
(deleted), image/jpeg
Details 
I suspect that the code on that page somehow fails to detect the menu choice, and so compares the hash in the CC number with the default entries, as opposed to the ones I picked.  That's why I picked DOM Core & HTML, but I could be off.

I tried w/ Safari, with the same numbers, and it worked there. 

(URL on the bug, but it requires login, an account, etc.)
Is this a regression? Regression range would be very useful.
Works fine with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.15pre) Gecko/2009100304 GranParadiso/3.0.15pre ID:2009100304

Looks like a regression on 1.9.1. Anyone who can run a regression test?
Severity: normal → major
Keywords: regression, regressionwindow-wanted
Now when running the same steps in shiretoko again it works fine. David, do you have some good STR?
Note I was using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091002 Minefield/3.7a1pre

I don't have STRs, sorry.
David, you don't want to give your credit card info so we could try ;) So, is this only a 1.9.2 and 1.9.3 then?
One other possible thought is that Minefield is confusing some user-agent sniffing that amazon might be doing.  I suspect it's 1.9.3 only, given comment #3.
No, as I said in comment 3 I saw the same problem with Shiretoko before I run a test with Gran Paradiso. I have retested Namoroka and Minefield again and both versions from today are working fine.

David, can you still reproduce the problem with any of todays builds?

My steps:
1. Choose option to add a credit card payment method.
2. Select the type of credit card
3. Enter the credit card number
4. Enter the name
5. Select the exiration date
6. Click on a button which assigns the correct address

After those steps my credit card information is successfully added without any problem.
Tried w/ Namoroka nightly, and it worked fine.

Tried again w/ Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091003 Minefield/3.7a1pre, and it still failed.

STRs:

1. add something to card, proceed to payment (this gets you to a different credit card adding page
2. when you get to "Select a Payment method" (https://www.amazon.com/gp/checkout/ship/select.html/ref=ox_shipoption_continue), add a new card
3.  enter credit card number, name, expiration date, credit card type
4. click on "add your card"

-> it complains about a bad expiration date.
Thanks David. Those steps were really helpful! I'm able to reproduce it and got the following regression range for Minefield (090916 - 090917)

Pass: http://hg.mozilla.org/mozilla-central/rev/38754465ffde
Fail: http://hg.mozilla.org/mozilla-central/rev/3079370d6597

Changesets: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=38754465ffde&tochange=3079370d6597

Could be another regression of one of the patches in the Tracemonkey merge.
Definitely a Tracemonkey merge regression. I'll bisect.
Another regression from bug 471214.
Blocks: 471214
Keywords: regressionwindow-wanted
Flags: blocking1.9.2?
Any hope of a testcase extracted from the site JS?

/be
The verification is done via XHR. So I don't really know where to start. I tried with Firebug but wasn't successful. Olli or Martijn, has one of you an idea?
Likely dup of bug 518103.

/be
Assignee: nobody → general
Component: DOM: Core & HTML → JavaScript Engine
OS: Mac OS X → All
QA Contact: general → general
Hardware: x86 → All
The tracemonkey hourly build that includes

http://hg.mozilla.org/tracemonkey/rev/2c1129dc9062

should be tested to see if it cures this bug's symptom. If so, please dup this bug against bug 518103. Thanks,

/be
This WFM on my tracemonkey tip build, now that bug 518103 has been fixed.

/be
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
It's not fixed for me with the steps given in comment 8 and the latest available tracemonkey build on tinderbox with 0a1c844e781a included. That one is 3 checkins later as the ones from bug 518103.

=> Reopen
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Status: REOPENED → NEW
I can't get to that page. Maybe I need to make a new amazon.com account?

Any console errors?

/be
Attached image screenshot (deleted) — 
Should work with your current account. Just make sure to follow the steps above and click on the small button in the sidebar at the right bottom corner which is named "Payment methode <Change>". See the screenshot. There are different web pages which offer to enter a credit card. As you can see above I have also choosen the wrong one while testing it the first time. Does that help?

As far as I can see no errors are reported.
Tested again (for verification) with the latest tracemonkey build and it is still visible: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091006 Minefield/3.7a1pre ID:20091006120010
Assignee: general → brendan
Status: NEW → ASSIGNED
Priority: -- → P1
Flags: blocking1.9.2? → blocking1.9.2-
Henrik, could you please try the patch in bug 524826 -- it may (I hope will) fix this bug too. Thanks,

/be
Fix for 524826 just hit tm and m-c -- see bug 524826 comment 43.

/be
Brendan, this problem seems to be solved even without the patch on bug 524826. I cannot reproduce the failure with a Minefield build 091118.

David, are you able to reproduce it with yesterdays nightly build? If yes, can you try with todays nightly and check if it is fixed?
I'm not sure what fixed this. We should find out. If it wasn't anything fixed to cure a problem in the patch for bug 471214, then please make this block the true regressor.

/be
If someone has the energy to bisect and id the fix, please mark FIXED and cite it.

/be
Status: ASSIGNED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: