Closed
Bug 520622
Opened 15 years ago
Closed 15 years ago
use windows style paths for windows mobile build
Categories
(Firefox Build System :: General, defect)
Tracking
(status1.9.2 beta5-fixed)
RESOLVED
FIXED
mozilla1.9.3a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta5-fixed |
People
(Reporter: blassey, Assigned: blassey)
References
Details
(Keywords: mobile)
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
beltzner
:
approval1.9.2+
|
Details | Diff | Splinter Review |
PyMake currently doesn't handle msys paths well.
Attachment #404679 -
Flags: review?(ted.mielczarek)
Comment 1•15 years ago
|
||
Comment on attachment 404679 [details] [diff] [review]
patch
-_topsrcdir=`cd \`dirname $0\`; pwd`
-_objdir=`pwd`
+case "$target" in
+*-wince*)
+ _topsrcdir=`cd \`dirname $0\`; pwd -W`
+ _objdir=`pwd -W`
+ ;;
I don't think this is necessary. $_objdir isn't really used anywhere important, and $_topsrcdir is only used in one place, AFAICT. I'd just get yourself a $_topsrcdirwin here, where it's actually used:
make OGLES_SDK_DIR="$OGLES_SDK_DIR" WINCE_SDK_DIR="$WINCE_SDK_DIR" TOPSRCDIR="$_topsrcdir" OBJDIR="$_pwdw" -C $srcdir/build/wince/tools
_pwdw=`pwd -W`
- _pwd=`pwd`
+ _pwd=`pwd -W`
This seems silly. Just drop $_pwdw here, make $_pwd be the windows-style path, and make everything use it. Everything handles these forward-slash Windows paths just fine, AFAIK.
CYGWIN_WRAPPER="${srcdir}/build/cygwin-wrapper"
if test "`echo ${srcdir} | grep -c ^/ 2>/dev/null`" = 0; then
- _pwd=`pwd`
+ _pwd=`pwd -W`
CYGWIN_WRAPPER="${_pwd}/${srcdir}/build/cygwin-wrapper"
You don't want to change this. This is strictly for Cygwin support. (We should just drop that at some point.)
r=me with those changes.
Attachment #404679 -
Flags: review?(ted.mielczarek) → review+
Updated•15 years ago
|
Assignee: nobody → bugmail
Assignee | ||
Comment 2•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Attachment #404679 -
Flags: approval1.9.2?
Comment 3•15 years ago
|
||
Comment on attachment 404679 [details] [diff] [review]
patch
a192=beltzner
Attachment #404679 -
Flags: approval1.9.2? → approval1.9.2+
Assignee | ||
Comment 4•15 years ago
|
||
status1.9.2:
--- → final-fixed
Updated•15 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a1
Updated•15 years ago
|
Blocks: C192ConfSync
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•