Closed Bug 520626 Opened 15 years ago Closed 6 years ago

Get rid of pointless QI calls

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INACTIVE

People

(Reporter: taras.mozilla, Unassigned)

References

Details

we have a lot of pointless qi calls.

nsIFile->nsILocalFile(and friends)

most nsIInputStream->nsSeekableStream QIs could be done away with.
Not only do these qi, but they also are immediately followed by error checks.

I think as a solution would be some static analysis soup and code that expands to something like static_cast<nsIDerived> foo = abstract;
I assume this would also catch cases like 575900 where a QI can be replaced with an *implicit* static cast.
Summary: Get rid of pointless qi calls → Get rid of pointless QI calls
Product: Core → Firefox Build System
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.