Closed Bug 520801 Opened 15 years ago Closed 15 years ago

Taskbar Previews Win7 not working

Categories

(Core :: Widget: Win32, defect, P1)

x86
Windows NT
defect

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: jmjjeffery, Assigned: jimm)

References

Details

Attachments

(1 file, 3 obsolete files)

Using a build from today's nightly, the Aero-preview from the taskbar does not work on my system. I see this error in the Console 2, and with a new Profile: Error: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import] Source file: chrome://browser/content/browser.js Line: 2540 I've checked the 3 aero pref's in about:config and its enbabled and set to 20, and 20 for the other pref's. IE8 works, as does Aero 3D flip, so I know my system supports Aero. AMD Phenom II X-4 Quad , ATI HD3200 onboard video card on an HP Pavilion, 8gig RAM, with Win7 RC build 7100 installed clean on its own hard-drive in a dual-boot config. Will updating to Full RTM at end of month as soon as my copy of Win7 arrives. Others in the builds forums at Mozillazine are stating it works for them and they didn't do anything special, just updated to latest nightly.
Blocks: 474056
No longer blocks: 501490
Is this a trunk build or 1.9.2? That browser.js line number lands in a funny place - http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#2524
browser.js is preprocessed, so it's a different line.
I was using hourly builds, and I double checked to see that I was using a build that contained the patches. I just installed an older build from here: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1254823743/ Still didn't work, then I used: Help->check for updates and updated to today's nightly m-c build, and lo-and-behold , it started working, for how long now is anyone guess.. still testing, but I have to leave for work and will be tomorrow before I can pick up more testing. Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091006 Minefield/3.7a1pre Firefox/3.7 (.NET CLR 3.5.30729) ID:20091006044117
Rob, I just hit this bug downloading the latest trunk hourly 1254866942, I didn't update the partial nightly or do anything else besides install the hourly and open tabs and tried to check taskbar tab previews. Error: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: chrome://browser/content/browser.js :: anonymous :: line 2535" data: no] Here is the about:buildconfig from m-c. cl 14.00.50727.762 -TC -nologo -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1 cl 14.00.50727.762 -GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1
Do you have a preview-per-tab.jsm file in $(FIREFOX)/modules/wintaskbar/ ? I have today's nightly and have the file (hence no error for me).
I deleted the minefield folder and re-installed a 10/5 hourly and installed more hourly and still no folder/file exists. So basically the folder and file only gets installed on the nightly but not the hourly. I tested this by re-installed a 10/5 trunk hourly and then updated to the 10/6 partial nightly. On browser load, taskbar previews work, the folder/file exists. But now there is more fun: I downloaded another latest hourly but when the browser loaded up (even before manually adding tabs) the same error again shows up and previews don't work again. .. but now I got another error on top of that with the latest m-c hourly 1254869248 build: Error: uncaught exception: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch2.getIntPref]" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: file:///C:/Program%20Files/Minefield/modules/wintaskbar/preview-per-tab.jsm :: anonymous :: line 556" data: no] The Branch partial nightly I updated to has the folder and file, but taskbar previews do not work at all, no errors either, and I checked the prefs. This is the same results I saw other users report on the mozillazine branch thread.
Ted, any ideas here? I'm in completely unfamiliar territory here.
Here is what I gather: The only thing we know works is the 10/06 partial trunk nightly and each build is producing different runtime results. Its like the code is not the same across builds and missing files or installing new hourly builds over code that works causes errors on trunk while branch doesn't.
Rob: my only guess is that maybe some of our build slaves either didn't get the Win7 SDK update installed properly, or didn't clobber, so are somehow still stuck with the old SDK, and thus not building the Windows 7 bits. Generally, a bug in your makefiles or packaging will either manifest or not. If we're producing some builds with this file and some without, then it's likely to be a issue with our build slaves.
Looks like bug 520327 to revert back to Vista SDK landed the same day the Win7 bug fixes landed which needs the Win7 SDK and I found bug 520765 - Fennec build failed from Win7 SDK after bug 505504 landed to add the Win7 SDK.
bug 520327 is about Thunderbird and SeaMonkey builds.
Last night's nightly has the same problem for me on win7 - Error: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: chrome://browser/content/browser.js :: anonymous :: line 2535" data: no] The jsms & wintaskbar folder are also missing from (install)/modules/. I wonder if this has something to do with browser/makefiles.sh? I'm not familiar with what that does, but it has all the component paths listed and seem to tie in with the build of the install. Once I created that folder and copied the files in, venkman indicates the preview jsm as loaded, and the error goes away. however, I'm not seeing previews yet for some reason. Doing some more investigating...
browser/makefiles.sh just tells configure what makefiles to generate. Having things missing there generally isn't a problem, since make will generate makefiles on the fly. It's just faster to let configure generate them all at once, usually.
bits are compiled in in last night's nightly - const Cc = Components.classes; const Ci = Components.interfaces; const WINTASKBAR_CONTRACTID = "@mozilla.org/windows-taskbar;1"; Cc[WINTASKBAR_CONTRACTID] @mozilla.org/windows-taskbar;1 var test = Cc[WINTASKBAR_CONTRACTID].getService(Ci.nsIWinTaskbar); test [xpconnect wrapped nsIWinTaskbar] test.available true jump lists also are working with the file copies.
(In reply to comment #14) > browser/makefiles.sh just tells configure what makefiles to generate. Having > things missing there generally isn't a problem, since make will generate > makefiles on the fly. It's just faster to let configure generate them all at > once, usually. Ok, so we should probably add the new component makefiles to this I guess. Will put together a patch.
Flags: blocking1.9.2+
Priority: -- → P1
So does bug 518666 comment 70 explain the original problem here?
FWIW, with the 10-07 nightly I'm not seeing anything in the error console, no Aero Peek (using Windows 7 RC)
Also note: Bug 520937 is about hitting errors with the WINTASKBAR_CONTRACTID code being referenced undefined.
Attached patch touchup fix for modules v.1 (obsolete) (deleted) — Splinter Review
Assignee: nobody → jmathies
We should probably add a "Windows" prefix to the jsm file names when they aren't contained in wintaskbar/ anymore.
Attached patch touchup fix for modules v.2 (obsolete) (deleted) — Splinter Review
Attachment #405138 - Attachment is obsolete: true
Comment on attachment 405143 [details] [diff] [review] touchup fix for modules v.2 diff --git a/browser/components/wintaskbar/jumpLists.jsm b/browser/components/wintaskbar/winJumpLists.jsm rename from browser/components/wintaskbar/jumpLists.jsm rename to browser/components/wintaskbar/winJumpLists.jsm diff --git a/browser/components/wintaskbar/preview-per-tab.jsm b/browser/components/wintaskbar/winPreviewPerTab.jsp rename from browser/components/wintaskbar/preview-per-tab.jsm rename to browser/components/wintaskbar/winPreviewPerTab.jsp diff --git a/browser/makefiles.sh b/browser/makefiles.sh The rename didn't show up in the annotated diff for some reason? Hope this'll still work.
Attachment #405143 - Flags: review?(dao)
Attached patch touchup fix for modules v.3 (obsolete) (deleted) — Splinter Review
Attachment #405143 - Attachment is obsolete: true
Attachment #405143 - Flags: review?(dao)
Attached patch touchup fix for modules v.3 (deleted) — Splinter Review
Now Windows*
Attachment #405145 - Attachment is obsolete: true
Attachment #405146 - Flags: review?(dao)
Attachment #405146 - Flags: review?(dao) → review+
Attachment #405146 - Flags: approval1.9.2?
Comment on attachment 405146 [details] [diff] [review] touchup fix for modules v.3 Not needed - this is a blocker. Check this in!
Attachment #405146 - Flags: approval1.9.2?
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Latest branch hourly 15:01 is still busted, our two files do not exist in the modules folder. Based on the checkins, I would think the two bugs should of have been compiled in by now.
(In reply to comment #28) > Latest branch hourly 15:01 is still busted, our two files do not exist in the > modules folder. Based on the checkins, I would think the two bugs should of > have been compiled in by now. Last night's 1.9.2 nightly seems to be working fine. Note, there is only one file, WindowsPreviewPerTab.jsm, and it would be in the modules directory. Can you confirm this isn't what you're seeing?
Yeah, all I have is the 1 file, WindowsPreviewPerTab.jsm in the modules directory. Previews and jumplists don't run just installing the 15:01 hourly in a clean folder, I deleted the Namoroka directory after I noticed un-installing from control panel didn't kill it. (In reply to comment #28) > our two files do not exist in the modules folder. I've been trying to test the bug on Flyouts too and messed up what I was doing when I saw this, so I noticed before you commented, since I can view my Vista drive in 7, I saw that.
(In reply to comment #30) > Yeah, all I have is the 1 file, WindowsPreviewPerTab.jsm in the modules > directory. Previews and jumplists don't run just installing the 15:01 hourly > in a clean folder, I deleted the Namoroka directory after I noticed > un-installing from control panel didn't kill it. > > (In reply to comment #28) > > our two files do not exist in the modules folder. > > I've been trying to test the bug on Flyouts too and messed up what I was doing > when I saw this, so I noticed before you commented, since I can view my Vista > drive in 7, I saw that. I believe Namoroka support for aero peek is still busted due to bug 521265.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: