Closed Bug 52106 Opened 24 years ago Closed 8 years ago

<menulist> menus should pop up with chosen option under cursor

Categories

(Core :: XUL, defect, P3)

PowerPC
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: mpt, Assigned: enndeakin)

References

(Depends on 1 open bug)

Details

(Keywords: helpwanted)

Attachments

(1 file)

Build: 2000090820, Mac OS 9.0 Steps to reproduce: * Get a job at an Internet cafe which uses IE 5 for Windows. * Offer to help a customer who hasn't used computers before, but wants to `get a Hotmail address'. Show said customer the basics of using a mouse. * Take customer to <http://lc6.law5.hotmail.passport.com/cgi-bin/register>. * Watch as customer fills out `First Name' and `Last Name'. * Remind customer that they must specify that they're in New Zealand, not the United States, otherwise Hotmail will insist that they enter a Zip code which they don't have. * Watch as customer clicks on the triangle-button part of the `Country/Region' popup menu and scans the list of countries. United States, United States Outlying Islands, Uruguay, Uzbekistan, Vanuatu, Vatican City State ... * Grit your teeth in annoyance as, JUST LIKE EVERYONE ELSE with the same level of computer experience in the same situation, this user fails to work out how to choose an item (`New Zealand') above the current one (`United States') in the popup menu, and has to ask you for help. * Repeat your silent wish that Windows popup menus worked like Mac ones, so that the method of getting to an item above the current one wasn't so smegging difficult to work out. Erm, yes. At the moment, <menulist>s on the Mac are behaving like ordinary <menu>s, and they shouldn't. They should pop up with the currently chosen item right under the cursor. Being a natural pessimist I don't expect you'll apply this behavior to <menulist>s in Windows, too, but if you did my job would be quite a bit more enjoyable.
I'm all for this on Mac. And I'm all for MS improving their poor implementation of combo boxes on Windows. But until they do, this should be Mac-only.
->future
Target Milestone: --- → Future
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla1.0
Blocks: 39403
Target Milestone: mozilla1.0 → mozilla0.8
pushing out
Target Milestone: mozilla0.8 → mozilla1.0
Keywords: helpwanted
Target Milestone: mozilla1.0 → mozilla0.9.8
not gonna happen in 098
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Target Milestone: mozilla0.9.9 → mozilla1.0
I'm thinking nsbeta1-... low severity. Push it out
Keywords: nsbeta1-
Target Milestone: mozilla1.0 → mozilla1.2
fffffffuture
Target Milestone: mozilla1.2alpha → Future
This bug is targeted at a Mac classic platform/OS, which is no longer supported by mozilla.org. Please re-target it to another platform/OS if this bug applies there as well or resolve this bug. I will resolve this bug as WONTFIX in four weeks if no action has been taken. To filter this and similar messages out, please filter for "mac_cla_reorg".
OS: Mac System 8.5 → MacOS X
This is still relevant. We should fix it in our menu code.
Assignee: mikepinkerton → nobody
Status: ASSIGNED → NEW
QA Contact: jrgmorrison → xptoolkit.menus
Target Milestone: Future → ---
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
Blocks: 1173111
I had this patch sitting around for a while and polished it off. It enables this for all menulists, but disables it for e10s selects for now. It didn't work perfectly and we can do that in another bug. Two differences from native behaviour: 1. When the menulist popup would extend off the edge of the screen, the OS normally displays arrows to scroll so that the position is maintained over the selection. For very small popups, it instead flips them to be onscreen ignoring the selection. This patch does the latter always due to some sizing issues I want to investigate more. 2. Click and drag to open the menu on the OS closes the menu if the mouseup occurs outside the popup. We could solve this with a mouse capture check or something in a followup bug.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #8757297 - Flags: review?(mstange)
Note also that this is obviously Mac specific but you can use this behaviour on non-Mac with <menupopup position="selection">
Comment on attachment 8757297 [details] [diff] [review] Open menulist at position of selected item Review of attachment 8757297 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the long delay here. This patch improves things; if we start to use native menus for this at some point we can still back out this patch. I thought I might get a chance to play with that sooner, but I haven't gotten around to it yet, so let's land this in the meantime. And judging by bug 1091592 it seems like we might not even want native-looking popups for <select>s any more. :(
Attachment #8757297 - Flags: review?(mstange) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Depends on: 1308233
Depends on: 1315066
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: