Katsuhiko Momoi Reporter
	Description • 24 years ago

** Observed with 9/11/2000 Win32 build **

As dicussed in Bug 47343, the order of Character Coding
menus at the 1st tier is not according to the spec due to
some blocking bugs. 

This forces us to have the following structure on the 1st tier right
now:

 Character Coding --->

                       Auto-Detect 
                       More ...
                       Customize ...
                       ----------------------
                        (Static menu items)
                        (Cached menu items)

================================

This not good UI because the user has no idea as to what "More ..." or 
"Customize ..." mean. We need to come up with better UI.
So until the menus can be ordered according to the spec, we should
come up with alternative UI names. 

Here's one suggestion. (Please suggest others if you can think of
something better.)
==================================
Character Coding --->

                       Auto-Detect 
                       Select other encoding...
                       Customize ...
                       ----------------------
                        (Static menu items)
                        (Cached menu items)

================================

	Frank Tang
	Comment 1 • 24 years ago

It should never be something "..." since it have sub menu.

	Frank Tang
	Comment 2 • 24 years ago

Change "More" to "Additional". Mark it as M21

	bobj
	Comment 3 • 24 years ago

Why is "Additional" any more clear than "More"?

	Teruko Kobayashi
	Comment 4 • 24 years ago

Changed QA contact to ylong@netscape.com.

	Frank Tang
	Comment 5 • 24 years ago

move all cata's bug to ftang

	Frank Tang
	Comment 6 • 24 years ago

nhotta- simple change, can you help ?

	nhottanscp
	Comment 7 • 24 years ago

So "More" to "Select other encoding" and no change for "Customize..."?

	bobj
	Comment 8 • 24 years ago

"Select other encoding" is too long for a menu item.  We need something
more terse.

	nhottanscp
	Comment 9 • 24 years ago

So what's wrong with "More"? That's generically used (e.g. more fonts).

	Katsuhiko Momoi Reporter
	Comment 10 • 24 years ago

It's where the menu "More ..." occurs. If it is right after 
encoding items, it make sense, but in this position it does
not.

	Katsuhiko Momoi Reporter
	Comment 11 • 24 years ago

How about "Other encodings"?

	Prognathous Assignee
	Comment 12 • 22 years ago

Please add "Customize..." to the summary-line of this bug. I was just about to
open a new bug.

Ok, here are my suggestions:

I would change "Customize..." to "Customize list...", after all, the list of
encodings is the only thing available for customization. As it is, the word
"Customize" alone, suggests that the user could potentially customize the "User
defined" language using this option (while it's actually done using the Fonts
prefs panel).

As Katsuhiko Momoi suggested, "Other encodings" instead of "More" makes perfect
sense. It is clear and unambiguous.

Prog.

	Prognathous Assignee
	Comment 13 • 21 years ago

Taking bug. It sounds within my very limited coding abilities ;-)

I'm also changing the summary from:
  Character Coding: Need to modify "More.." as something else
to:
  Character Encoding: Replace "More >" and "Customize..." with easier to
understand names

Prog.

	Prognathous Assignee
	Comment 14 • 20 years ago

The patch changes "More" to "More Encodings" and "Customize..." to "Customize
List..."

Prog.

	Simon Montagu :smontagu
	Comment 15 • 20 years ago

Comment on attachment 153263 [details] [diff] [review]
Less ambiguous names for Encoding menu

I'm not a big fan of compensating for bad UI by modifying menu labels, but I
suppose this doesn't make the UI any worse.

	Prognathous Assignee
	Comment 16 • 20 years ago

Thanks for the reviews. Now, I'd like to get this checked into all three
branches. Is that the way it's done by default when the code is the same?

http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/locale/en-US/charsetOverlay.dtd
http://lxr.mozilla.org/mozilla1.7/source/xpfe/global/resources/locale/en-US/charsetOverlay.dtd
http://lxr.mozilla.org/aviarybranch/source/xpfe/global/resources/locale/en-US/charsetOverlay.dtd

Prog,

	Asaf Romano (gone)
	Comment 17 • 20 years ago

Prog, the version of the dtd file for AVIARY is in the new toolkit:
http://lxr.mozilla.org/aviarybranch/source/toolkit/locale/charsetOverlay.dtd

Still, it has the same content.

----
BTW, why whole XPFE is still exists in the AVIARY branch?

	Christian :Biesinger (don't email me, ping me on IRC)
	Comment 18 • 20 years ago

(In reply to comment #16)
> Thanks for the reviews. Now, I'd like to get this checked into all three
> branches.

you need to ask for approval for the 1.7 branch (in the edit attachment page,
choose approval1.7.2?). not sure what the policy is for the aviary branch.

	Mike Connor [:mconnor]
	Comment 19 • 20 years ago

just needs review for aviary, but I'm not sure "Customize List" is really any
better.

	Prognathous Assignee
	Comment 20 • 20 years ago

I've outlined my rational of preferring "Customize List..." in comment 12. Which
part of it do you not agree with, Mike?

Prog.

	Prognathous Assignee
	Comment 21 • 20 years ago

Just to update my previous comment on the subject, "Customize" by itself, hints
that the whole Character Encoding UI+mechanism can be customized (inclue/exclude
sub-menus and options, set default encoding and so on...), while "Customize
List" doesn't suffer from this ambiguity.

Prog.

	Mike Kaply [:mkaply]
	Comment 22 • 20 years ago

Comment on attachment 153263 [details] [diff] [review]
Less ambiguous names for Encoding menu

We're not taking i18n changes on the 1.7.2 branch, although I admit this one is
probably OK because it doesn't break langpacks. blizzard?

	Asaf Romano (gone)
	Comment 23 • 20 years ago

CCing blizzard (see last comment).

	Prognathous Assignee
	Comment 24 • 20 years ago

(In reply to comment #19)
> just needs review for aviary, but I'm not sure "Customize List" is really any
> better.

How can I ask for review when the review flag is already set ("smontagu:
review+")? Should I file a new bug for Firefox?

Prog.

	Asaf Romano (gone)
	Comment 25 • 20 years ago

(In reply to comment #24)
> (In reply to comment #19)
> > just needs review for aviary, but I'm not sure "Customize List" is really any
> > better.
> 
> How can I ask for review when the review flag is already set ("smontagu:
> review+")? Should I file a new bug for Firefox?
> 
> Prog.

Not a new bug, but a version of your patch for the toolkit file (comment 17).

	Mike Connor [:mconnor]
	Comment 26 • 20 years ago

when you attach the patch, request review at that point.

	Prognathous Assignee
	Comment 27 • 20 years ago

Same patch, for Firefox trunk.

Prog.

	Christian :Biesinger (don't email me, ping me on IRC)
	Comment 28 • 20 years ago

checked in on trunk
Checking in charsetOverlay.dtd;
/cvsroot/mozilla/xpfe/global/resources/locale/en-US/charsetOverlay.dtd,v  <-- 
charsetOverlay.dtd
new revision: 1.17; previous revision: 1.16
done

	Prognathous Assignee
	Comment 29 • 20 years ago

Comment on attachment 153458 [details] [diff] [review]
Patch for Firefox

mconnor, can you please review the patch? It would be nice to have the same
Encoding menu in Firefox and Seamonkey. This patch is already checked into
1.8/trunk.

I'm asking for approval-aviary (before I have an r= for the patch), as time is
running out for UI changes.

Thanks,

Prog.

	Mike Kaply [:mkaply]
	Comment 30 • 20 years ago

Comment on attachment 153458 [details] [diff] [review]
Patch for Firefox

a=mkaply for aviary

	Asaf Romano (gone)
	Comment 31 • 20 years ago

Simon, can you please check it in?

	Asaf Romano (gone)
	Comment 32 • 20 years ago

We also need to check it into trunk...

	Simon Montagu :smontagu
	Comment 33 • 20 years ago

It has been checked into trunk already: see comment 28 and
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/xpfe/global/resources/locale/en-US/charsetOverlay.dtd

	Asaf Romano (gone)
	Comment 34 • 20 years ago

Firefox/Thunderbird doesn't use xpfe:
toolkit/locale/charsetOverlay.dtd

	Simon Montagu :smontagu
	Comment 35 • 20 years ago

Oh wait, you meant check in the *firefox* patch into trunk. Sorry, that is now
done too.