Closed
Bug 523087
Opened 15 years ago
Closed 15 years ago
[HTML5] Check for termination before every tree op
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
mozilla+ben
:
review+
|
Details | Diff | Splinter Review |
If something calls into nsIParser::Terminate() during a tree op flush, mParser of nsContentSink is nulled out and subsequent use thereof crashes.
Need to prepare for Terminate() getting called at various points.
|
Assignee | |
Comment 1•15 years ago
|
||
|
|
Assignee | |
Updated•15 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #407024 -
Attachment is obsolete: true
Attachment #407513 -
Flags: review?(bnewman)
|
|
Assignee | |
Comment 3•15 years ago
|
||
Oops. Forgot to return early if mParser has been nulled out.
Attachment #407513 -
Attachment is obsolete: true
Attachment #408573 -
Flags: review?(bnewman)
Attachment #407513 -
Flags: review?(bnewman)
|
||
Updated•15 years ago
|
Attachment #408573 -
Flags: review?(bnewman) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Thank you for the review.
Landed as http://hg.mozilla.org/mozilla-central/rev/1e2197526df0
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•