make mozilla.com/en-US/plugincheck/index.html easy to localize.

First attempt adds a hidden div to the page and 1 div per string with HTML comments for the L10n team. After page load, the JavaScript will extract these strings for use in the page.

Note: Bug#523145 is an issue that affects L10n, but doesn't block this bug.

Adding the full index.html for reference.

Adding the full page for reference.

Attaching mozilla.com patch 3rd version

Attaching Perfidies portion of the patch 3rd version

The plain messages.js for reference in addition to the two patch files.

The index.php file will cause some function that outputs the JavaScript for "external strings" which override "internal strings" that are defined in the global JS. (Per http://pastebin.mozilla.org/677503) Pascal, please let me know if I understood you with this newest set of patches and any other feedback, thanks.

Comment on attachment 407175 [details] [diff] [review] new messages.js file added to Perfidies build Should be all that we need to make it localizable, thanks Ozten

I am keeping this bug open as we may encounter other issues during the implementation of the localized version, I will create a test version tomorrow.

I wanted to see where we are at. I'm making other changes that conflict with this one, so I've moved this off into a branch. Let me know when this is ready and we can put it into http://www-trunk.stage.mozilla.com/en-US/plugincheck

Hi Austin, is it already time to localize the three files in attachment or do we have to wait for a your "call for localizers"? Thank you!

(In reply to comment #13) Hi Giuliano, I'd check with Pascal and the other L10n organizers to see if we're ready to start.

I have one concern about your variables, it looks like Pfs_internal is not defined in your library so redefining its values from a Pfs_external will have no effect, have you changed the variable name used in the dynamic table for strings? Also, I noticed that the side menu item "Which Plugins do I have?" is not linking to a valid anchor name, should be #list-plugins and not #my-plugins

I have committed the first draft in r57173, Austin you can "see" it there: http://www-trunk.stage.mozilla.com/fr/plugincheck/ At the moment, I need to know what the name of the array I should use and also if there are new strings added to the 18 in your previous attachment.

(In reply to comment #15) Per comment #12, I had to remove this code. I've added it back in on trunk and https://www-trunk.stage.mozilla.com/en-US/plugincheck/. Sending js/plugincheck.js Transmitting file data . Committed revision 57480.

(In reply to comment #15) I touched includes/headers/plugincheck-l10n.inc.php... In the console it looks good... seeing ["Checking with Mozilla HQ to check your pluginsFOOBAR", "Loading DataFOOBAR", "View All Your PluginsFOOBAR", "Disable NowFOOBAR", "Vulnerable No FixFOOBAR", "Update NowFOOBAR", "VulnerableFOOBAR", "UpdateFOOBAR", "Outdated VersionFOOBAR", "Up to DateFOOBAR", "ResearchFOOBAR", "Unable to Detect Plugin VersionFOOBAR", "ofFOOBAR", "plugins are vulnerable wih no update availableFOOBAR", "plugins are vulnerableFOOBAR", "plugins are potentially vulnerableFOOBAR", "The plugins listed below are up to dateFOOBAR", "No plugins were detectedFOOBAR", "http://www.google.com/search?q=FOOBAR", "current version pluginFOOBAR"] ["Checking with Mozilla HQ to check your pluginsFOOBAR", "Loading DataFOOBAR", "View All Your PluginsFOOBAR", "Disable NowFOOBAR", "Vulnerable No FixFOOBAR", "Update NowFOOBAR", "VulnerableFOOBAR", "UpdateFOOBAR", "Outdated VersionFOOBAR", "Up to DateFOOBAR", "ResearchFOOBAR", "Unable to Detect Plugin VersionFOOBAR", "ofFOOBAR", "plugins are vulnerable wih no update availableFOOBAR", "plugins are vulnerableFOOBAR", "plugins are potentially vulnerableFOOBAR", "The plugins listed below are up to dateFOOBAR", "No plugins were detectedFOOBAR", "http://www.google.com/search?q=FOOBAR", "current version pluginFOOBAR"] The minor tweak I made to includes/headers/plugincheck-l10n.inc.php was to 1) Move including plugincheck.js to *after* where you define Pfs_external in JavaScript 2) Move the block of JavaScript which uses "$(document).ready" to after the plugincheck.js script tag.

We are doing work in Bug#528280 en-US/plugincheck/ to support create a "web badge" with many image sizes. You can either exclude this content or we can get the images localized also. They are all attached to the above bug. We are still finalizing the layout, etc of the en page.

Updated includes/headers/plugincheck-l10n.inc.php with fixes from Bug#535030 where new site wide jquery was breaking plugincheck. The plugincheck.js include and onready script block are put into the footer JS with the $extra_footers global variable. http://www-trunk.stage.mozilla.com/fr/plugincheck/ is working again.