Closed
Bug 523765
Opened 15 years ago
Closed 13 years ago
TM: remove all uncessary TempValueRooter uses
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: gal, Assigned: gal)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Conservative stack scanning obsoletes almost all uses of TempValueRooters in the engine. This bug aims at manually removing all unnecessary ones.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: general → gal
|
|
Assignee | |
Comment 2•15 years ago
|
||
So for I found one JSTempValueRooter that is still needed (in array_sort).
Whenever tvr.count is modified thats a good indicator that the interior of the rooter is not on the stack.
|
|
Assignee | |
Comment 3•15 years ago
|
||
(Note: there is only one other instance where we modify tvr.count, and that case is actually obsolete since the values are held on the stack, not in the heap.)
|
||
Comment 4•13 years ago
|
||
Obsolete with the removal of tracejit.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•