Closed
Bug 524620
Opened 15 years ago
Closed 15 years ago
TM: Clean up fragment hierarchy
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dvander, Assigned: dvander)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
This patch removes |root| and |vmprivate| from Fragment, which are TM-specific (I think).
Instead we now have:
nanojit::Fragment - base class.
TMFragment - inherits from nanojit::Fragment, base class for TraceMonkey.
REFragment - inherits from TMFragment.
TreeFragment - old "VMFragment", root of a tree.
vmprivate is now a |treeInfo| member of TreeFragment.
This reorganization is to make merge traces less painful.
|
||
Updated•15 years ago
|
Summary: TM: Clean up fragment heirarchy → TM: Clean up fragment hierarchy
|
Assignee | |
Comment 1•15 years ago
|
||
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #408539 -
Attachment is obsolete: true
Attachment #408689 -
Flags: review?(gal)
|
|
Assignee | |
Comment 3•15 years ago
|
||
Review ping, minus NJ changes, now that bug 526011 has landed on nj-central.
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #408689 -
Attachment is obsolete: true
Attachment #410329 -
Flags: review?(gal)
Attachment #408689 -
Flags: review?(gal)
|
||
Comment 5•15 years ago
|
||
Comment on attachment 410329 [details] [diff] [review]
rebased
New naming is urgh. I would prefer renaming as per discussion but up to you.
Attachment #410329 -
Flags: review?(gal) → review+
|
|
Assignee | |
Comment 6•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/06e6c525b8b7
Pushed with nits - TMFragment is VMFragment now.
Whiteboard: fixed-in-tracemonkey
|
||
Comment 7•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•