Closed
Bug 52502
Opened 24 years ago
Closed 24 years ago
Crash when administering my domain! :) (fix attached)
Categories
(Core :: Networking, defect, P3)
Tracking
()
People
(Reporter: pollmann, Assigned: gagan)
References
()
Details
I haven't had time to reduce the test case, but I get a consistent crash
dereferencing a null mChannel in nsHTTPServerListener::OnDataAvailable when
viewing this page. It is opening up a link in a new window:
<li><a href="mydomain/domain-info?domainid=53939"
target="_new">pollmann.com</a>
Here's a simple bullet-proofing fix:
Index: nsHTTPResponseListener.cpp
===================================================================
RCS file:
/cvsroot/mozilla/netwerk/protocol/http/src/nsHTTPResponseListener.cpp,v
retrieving revision 1.129
diff -u -r1.129 nsHTTPResponseListener.cpp
--- nsHTTPResponseListener.cpp 2000/09/05 21:22:33 1.129
+++ nsHTTPResponseListener.cpp 2000/09/13 18:53:10
@@ -464,6 +464,7 @@
if (NS_SUCCEEDED(rv) && i_Length) {
PRBool bApplyConversion = PR_TRUE;
+ if (!mChannel) return NS_ERROR_FAILURE;
(void) (mChannel->GetApplyConversion(&bApplyConversion));
if (bApplyConversion && !mCompressHeaderChecked)
Cool! This is a common crash now and I had the same fix already (not checked in
as yet though) Thanks for hunting it down. See bug 52397
*** This bug has been marked as a duplicate of 52397 ***
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•