Closed
Bug 525245
Opened 15 years ago
Closed 15 years ago
system-info should expose hardware specs to JS consumers
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(1 file)
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
I'm in need of knowing hardare specs (pagesize, memory size, cpus) to create a dynamic limit for history entries, so i can adapt history storage capabilities based on hardware we are running on.
I thought system-info was exposing them, but instead it's only exposing a subset of the available data.
Names are arguable, maybe instead of "cpus" could be "cpucount", not sure.
I added a small test just to ensure all expected properties are there, i can run on tryserver to check how various archs respond to this.
But first of all i'd like to have a guess if this could be fine or not.
Attachment #409100 -
Flags: review?(benjamin)
Comment 1•15 years ago
|
||
Comment on attachment 409100 [details] [diff] [review]
patch v1.0
I'm a little skeptical that NSPR is going to give us good data for all of these properties, but that's probably a different bug.
Attachment #409100 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 2•15 years ago
|
||
yeah i still have to check how "real" are them, but for now i need them exposed, especially the memsize, that we already use in Places to size the number of cached pages, should work fine.
what about names?
do you think "cpucount" is better than "cpus"?
Assignee | ||
Comment 3•15 years ago
|
||
pushed with "cpucount" as name, since sounds better and more widely used.
http://hg.mozilla.org/mozilla-central/rev/b7ad076f2d62
Assignee: nobody → mak77
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•