Closed Bug 525810 Opened 15 years ago Closed 15 years ago

Aero Peek incorrectly draws glass regions as solid black regions

Categories

(Firefox :: Shell Integration, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: ryancpratt, Unassigned)

References

Details

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b1) Gecko/20091029 Firefox/3.6b1 (.NET CLR 3.5.30729) Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b1) Gecko/20091029 Firefox/3.6b1 (.NET CLR 3.5.30729) When previewing tabs from the jump list, the aero tab switching displays a black theme instead of the "aero" theme I cam currently using. However, when I select a jump list preview, it jumps to that tab and the theme corrects itself. Reproducible: Always Steps to Reproduce: 1.install custom firefox theme (ex. All-Glass Firefox) 2.pause over windows 7 firefox dock icon. 3.hover over previews of opened tabs Actual Results: Aero peek functionality shows the firefox theme as black. Expected Results: The theme is actually "aero" Theme used: All-Glass Firefox mod Using Windows 7 Professional
Blocks: 474056
Component: Tabbed Browser → Shell Integration
QA Contact: tabbed.browser → shell.integration
You are using a theme that uses aero glass for the titlebar correct? We did not design or test for this. I think that the alpha channel that we use to paint might be set wrong but I'm also not sure in this case how the feature should work from a UI perspective. Also, if you could attach a screenshot or two of what you're seeing, that would be helpful.
The actual theme is "All-Glass Firefox mod, based on Glasser 2.0.2" This is what the theme looks like: [IMG]http://i525.photobucket.com/albums/cc333/ryancpratt/Untitled-1.jpg[/IMG] And this is what happens when you use the Firefox jump list preview: [IMG]http://i525.photobucket.com/albums/cc333/ryancpratt/Untitled-2.jpg[/IMG]
(In reply to comment #2) > The actual theme is "All-Glass Firefox mod, based on Glasser 2.0.2" > > This is what the theme looks like: > [IMG]http://i525.photobucket.com/albums/cc333/ryancpratt/Untitled-1.jpg[/IMG] > > And this is what happens when you use the Firefox jump list preview: > [IMG]http://i525.photobucket.com/albums/cc333/ryancpratt/Untitled-2.jpg[/IMG] To use these links, you'll just have to copy and paste the URL, the coding didn't work.
Ok. As I suspected, only the Aero Glass regions are being drawn as black. Do other themes work? I suspect the answer is yes.
(In reply to comment #4) > Ok. As I suspected, only the Aero Glass regions are being drawn as black. Do > other themes work? I suspect the answer is yes. You would be correct, other themes work. It only seems this problem is limited to Aero Glass themes.
Updating the bug title with an appropriate description of the bug. As I stated earlier, I suspect that we are not painting the alpha component correctly. I do need to know how the glass effect is being achieved however. If they are using color keying, then I think we cannot fix this (hence why the internal implementation of aero glass does not use color keying). Otherwise I suspect that GDI is dropping the alpha channel. Since we manage to paint the window correctly for Windows paint events, we may need to do something similar if we detect that we are drawing a glass window.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: FF3.6b1 windows 7 jump list tab previews display themes incorrectly → Aero Peek incorrectly draws glass regions as solid black regions
(In reply to comment #6) > Updating the bug title with an appropriate description of the bug. As I stated > earlier, I suspect that we are not painting the alpha component correctly. I do > need to know how the glass effect is being achieved however. If they are using > color keying, then I think we cannot fix this (hence why the internal > implementation of aero glass does not use color keying). Otherwise I suspect > that GDI is dropping the alpha channel. Since we manage to paint the window > correctly for Windows paint events, we may need to do something similar if we > detect that we are drawing a glass window. Well, if you need any more info I'll gladly help as much as I can.
(In reply to comment #7) > Well, if you need any more info I'll gladly help as much as I can. You have been quite helpful and quick to respond, thanks! One last question: is this the correct theme: http://www.neowin.net/forum/index.php?showtopic=746714 ?
That's probably the correct theme, but here is the link to where I downloaded it from mozilla: https://addons.mozilla.org/en-US/firefox/addon/12181
In looking at existing glass themes, none seem to use our glass code in widget/ but instead use some closed source DLL to invoke DWM functions. During the brief period of time when the glass theme was enabled on trunk (which uses our glass code), this appeared to be working so I'm going to resolve this as invalid.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.