Closed
Bug 525820
Opened 15 years ago
Closed 7 years ago
Come up with a naming collision avoidance scheme for testing/xpcshell/head.js
Categories
(Testing :: XPCShell Harness, defect)
Testing
XPCShell Harness
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: Waldo, Unassigned)
Details
There's no documented scheme for naming of helper functions in the file, and we're courting collisions by not doing so. Come up with something not-too-intrusive and not-too-ugly and switch over to it.
Reporter | ||
Comment 1•15 years ago
|
||
Also: document it and enforce it somehow! (Maybe _execute_tests should loop over the global at test end and check for names that violate the scheme, to enforce that only a precise list of names are present.)
Another idea would be to encapsulate all functionality in a single object and then export individual functions on it. I don't really care what gets used.
Whiteboard: [good first bug]
Comment 2•15 years ago
|
||
(In reply to comment #1)
> Another idea would be to encapsulate all functionality in a single object and
> then export individual functions on it. I don't really care what gets used.
Sounds pretty reasonable to me. We should only be exposing the documented "do_*" methods.
Coming up with a "convention" to do something is not usually a "good first bug". We also want to transition these to mentored bugs. So, if this can be more clearly defined w.r.t. what we want then it could be a good mentored bug. Ted, would you mind being the mentor if a contributor shows up?
Flags: needinfo?(ted)
Whiteboard: [good first bug]
Comment 4•12 years ago
|
||
Without a concrete proposal here for what we'd want to do I don't think this is a good candidate for a mentored bug.
Flags: needinfo?(ted)
Comment 5•7 years ago
|
||
Mass closing bugs with no activity in 2+ years. If this bug is important to you, please re-open.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•