Closed
Bug 525834
Opened 15 years ago
Closed 15 years ago
Replace Search-glass.png with gtk-find stock icon
Categories
(Toolkit :: Themes, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
(deleted),
patch
|
ventnor.bugzilla
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #409667 -
Flags: review?(ventnor.bugzilla)
Comment 1•15 years ago
|
||
For some reason, I want to say we purposely went with a custom icon instead of gtk-find, but I can't remember why...
Assignee | ||
Comment 2•15 years ago
|
||
I also couldn't find anything about it, except for a comment that we should in fact use gtk-find. I've noticed that it's used in search fields throughout Ubuntu.
Comment 3•15 years ago
|
||
There's bug 424944 that talks about something similar that was WONTFIX'd (though, it was for using another icon).
Assignee | ||
Comment 4•15 years ago
|
||
We never seem to have used gtk-serach, so I'm not quite sure what the comments in that bug refer to. In any case, yes, it's about a different icon. As far as gtk-find is concerned, I think it's possible that previous Ubuntu icon themes used an icon that didn't fit. But it's a search glass now, and it's also a search glass on <http://library.gnome.org/devel/gtk/2.11/gtk-Stock-Items.html>.
Updated•15 years ago
|
Attachment #409667 -
Flags: review?(ventnor.bugzilla) → review+
Assignee | ||
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Assignee | ||
Updated•15 years ago
|
Attachment #409667 -
Flags: approval1.9.2?
Assignee | ||
Updated•15 years ago
|
Severity: minor → enhancement
Comment 6•15 years ago
|
||
The default GNOME icon theme still has binoculars as the find icon.
http://git.gnome.org/cgit/gnome-icon-theme/plain/16x16/actions/edit-find.png
Assignee | ||
Updated•15 years ago
|
Attachment #409667 -
Flags: approval1.9.2?
Assignee | ||
Comment 7•15 years ago
|
||
So... I think we want to stick with gtk-find for the generic search textbox widget, but cannot use it for the Firefox search bar. Other opinions?
Comment 8•15 years ago
|
||
Thunderbird tucks a dropmarker in next to Search-glass.png, so we wouldn't mind (going back to) sharing one in toolkit, if it's not possible to count on the shape of gtk-find.
Comment 9•15 years ago
|
||
We should have visual changes like this (particularly in the main window) go through ui-review prior to landing.
Comment 10•15 years ago
|
||
To clarify, for things like replacing one search glass with another more native one, ui-review is basically a rubber stamp on Linux, but the advantage is that we can have a full view of what is changing (for instance realizing that this icon wasn't native might trigger a thought to hunt down the other non-native icons, etc.)
You need to log in
before you can comment on or make changes to this bug.
Description
•