Closed Bug 526373 Opened 15 years ago Closed 14 years ago

Links using outgoing.m.o should use JavaScript to show the URL in the status bar

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Product:
addons.mozilla.org Graveyard
Component:
Public Pages
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
5.12.3

People

(Reporter: clouserw, Assigned: kumar)

References

(
URL
)

Details

Originally from bug 343573, we're replacing outgoing links with a redirect off outgoing.mozilla.org. We should replace the huge redirect URL in the status bar with the actual URL we redirect to. > The way htmlpurifier generates the link doesn't make it easy to inject > something like a class which we could key off of easily with some JS.
(In reply to comment #0) > > The way htmlpurifier generates the link doesn't make it easy to inject > > something like a class which we could key off of easily with some JS. a[href^=http://outgoing.mozilla.org] ?
(In reply to comment #1) > (In reply to comment #0) > > > The way htmlpurifier generates the link doesn't make it easy to inject > > > something like a class which we could key off of easily with some JS. > > a[href^=http://outgoing.mozilla.org] ? I was afraid that would be slow, but it would certainly work.
(In reply to comment #2) > (In reply to comment #1) > > (In reply to comment #0) > > > > The way htmlpurifier generates the link doesn't make it easy to inject > > > > something like a class which we could key off of easily with some JS. > > > > a[href^=http://outgoing.mozilla.org] ? > > I was afraid that would be slow, but it would certainly work. Meh, if it's at the end of the page, it wfm.
Target Milestone: --- → 4.x (triaged)
Assignee: nobody → thepotch
Assignee: thepotch → kumar.mcmillan
Target Milestone: 4.x (triaged) → 5.12.3
Fixed in https://github.com/jbalogh/zamboni/commit/03958c7e5e041ca41766238a0f60aabb58538b9a This will do some sneaky but harmless rewriting of the href attribute. Outgoing links will still work without JavaScript and the code is deferred to play nice with the page load. See it in action (when updated) at: https://addons.allizom.org/z/en-US/firefox/addon/215985/versions/ https://addons.allizom.org/z/en-US/firefox/addon/212330/versions/ et cetera.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Verified FIXED on the above two URLs.
URL: https://addons.allizom.org/z/en-US/fi...
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.