User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4 While compiling Mozilla Firefox source for 3.7a1pre, getting the below error. "/home/firefox/mozilla-central/js/src/jsvector.h", line 427.5: 1540-0130 (S) "AP" is not declared. "/home/firefox/mozilla-central/js/src/jsvector.h", line 426.1: 1540-0700 (I) The previous message was produced while processing "js::Vector<JSObject *,0,js::SystemAllocPolicy>::Vector(SystemAllocPolicy)". "/home/firefox/mozilla-central/js/src/jsapi.cpp", line 723.1: 1540-0700 (I) The previous message was produced while processing "JSRuntime::JSRuntime()". "/home/firefox/mozilla-central/js/src/jsvector.h", line 427.5: 1540-0130 (S) "AP" is not declared. "/home/firefox/mozilla-central/js/src/jsvector.h", line 426.1: 1540-0700 (I) The previous message was produced while processing "js::Vector<unsigned short,32,js::ContextAllocPolicy>::Vector(ContextAllocPolicy)". "/home/firefox/mozilla-central/js/src/jsapi.cpp", line 5490.18: 1540-0700 (I) The previous message was produced while processing "JS_Stringify(JSContext *, jsval *, JSObject *, jsval, extern "C" int (*)(const unsigned short *, unsigned int, void *), void *)". "/home/firefox/mozilla-central/js/src/jscntxt.h", line 1580.44: 1540-1281 (W) "offsetof" cannot be applied to "struct JSContext". It is not a POD (plain old data) type. gmake[1]: *** [jsapi.o] Error 1 Reproducible: Always Steps to Reproduce: 1. Build Mozilla Firefox 3.7a1pre build on AIX with Gnome RPMS of 64 bit version. 2. 3. Actual Results: Build fails with the above error. Expected Results: No build failure

The patch resolves the compilation error.

Comment on attachment 410199 [details] [diff] [review] Patch V 1 correcting request

Can you please review the patch and let me know if anything needs to be changed?

Can you please review the patch ?

Can someone review the patch please?

Comment on attachment 410199 [details] [diff] [review] Patch V 1 On it; sorry again for the delays.

For my own education, is there any reason to believe that this isn't an AIX compiler error? If it is a bug, is it solely with the naming of base classes? E.g., if you run the following snippet through the AIX compiler, do you get an error for either or both of the function definitions? template <class T> class A : T { A(); void foo(); }; template <class U> A<U>::A() : U() {} template <class U> void A<U>::foo() { U u; } Thanks! As for the patch, I'm wondering if, for regularity, we should convert all out-of-body definitions to use the same formal parameter names as the template definition.

Hi Luke Wagner, I compiled the snippet through AIX compiler, and no errors reported. Regards, Shailen

When I compile the snippet I get: $ /usr/vacpp/bin/xlC -qlanglvl=ansi -o naming.o -c naming.cpp "naming.cpp", line 2.11: 1540-0198 (W) The omitted keyword "private" is assumed for base class "T". "naming.cpp", line 5.13: 1540-0130 (S) "U" is not declared. $

(In reply to comment #9) Uli: Thanks! And does switching the 'U' on lines 4 and 5 to 'T' compile without error?

$ cat naming2.cpp template <class T> class A : T { A(); void foo(); }; template <class T> A<T>::A() : T() {} template <class U> void A<U>::foo() { U u; } $ /usr/vacpp/bin/xlC -qlanglvl=ansi -c naming2.cpp -o naming2.o "naming2.cpp", line 2.11: 1540-0198 (W) The omitted keyword "private" is assumed for base class "T". $ I'm using an older compiler version than Shailen because XLC/C++ 9 isn't supported on AIX 5.1. Here I used the version 6.0.0.7 I always built Mozilla 1.8 Branch with

Thanks again; that pretty much isolates the error.

Luke isn't a JS peer, according to http://www.mozilla.org/about/owners.html#javascript, so removing checkin-needed until a JS owner/peer can review the patch.

Reed, Luke's a peer. Someone needs to update despot, 'sall. Can you do it please? /be

(In reply to comment #14) > Reed, Luke's a peer. Someone needs to update despot, 'sall. Can you do it > please? I think I'll just give up trying to keep Despot in sync with CVS. *sigh* Despot account created for Luke, and I've made him a peer of JS.

Comment on attachment 410199 [details] [diff] [review] Patch V 1 This bug isn't fixed on mozilla-1.9.2 branch yet.

Renewing approval request for moz-192 branch. Risc: None. Fixed on trunk for more than a year now. moz-191 is unaffected.

Comment on attachment 410199 [details] [diff] [review] Patch V 1 a=LegNeato for 1.9.2.14. Code freeze for non-blockers is 2011-01-11.