User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4 While compiling Mozilla Firefox source for 3.7a1pre, getting the below error. "/home/firefox/mozilla-central/xpcom/io/nsWildCard.cpp", line 455.20: 1540-0274 (S) The name lookup for "ns_WildCardMatch" di d not find a declaration. "/home/firefox/mozilla-central/xpcom/io/nsWildCard.cpp", line 455.20: 1540-1292 (I) Static declarations are not considered fo r a function call if the function is not qualified. "/home/firefox/mozilla-central/xpcom/io/nsWildCard.cpp", line 448.1: 1540-0700 (I) The previous message was produced while pr ocessing "NS_WildCardMatch_<unsigned short>(const unsigned short *, const unsigned short *, PRBool)". "/home/firefox/mozilla-central/xpcom/io/nsWildCard.cpp", line 470.12: 1540-0700 (I) The previous message was produced while p rocessing "NS_WildCardMatch(const PRUnichar *, const PRUnichar *, PRBool)". "/home/firefox/mozilla-central/xpcom/io/nsWildCard.cpp", line 455.20: 1540-0274 (S) The name lookup for "ns_WildCardMatch" di d not find a declaration. "/home/firefox/mozilla-central/xpcom/io/nsWildCard.cpp", line 455.20: 1540-1292 (I) Static declarations are not considered fo r a function call if the function is not qualified. "/home/firefox/mozilla-central/xpcom/io/nsWildCard.cpp", line 448.1: 1540-0700 (I) The previous message was produced while pr ocessing "NS_WildCardMatch_<char>(const char *, const char *, PRBool)". "/home/firefox/mozilla-central/xpcom/io/nsWildCard.cpp", line 463.12: 1540-0700 (I) The previous message was produced while p rocessing "NS_WildCardMatch(const char *, const char *, PRBool)". gmake[5]: *** [nsWildCard.o] Error 1 "/home/firefox/mozilla-central/xpcom/io/nsWildCard.cpp", line 422.16: 1540-0274 (S) The name lookup for "_shexp_match" did not find a declaration. "/home/firefox/mozilla-central/xpcom/io/nsWildCard.cpp", line 422.16: 1540-1292 (I) Static declarations are not considered for a function call if the function is not qualified. "/home/firefox/mozilla-central/xpcom/io/nsWildCard.cpp", line 416.1: 1540-0700 (I) The previous message was produced while processing "ns_WildCardMatch<unsigned short>(const unsigned short *, const unsigned short *, PRBool)". "/home/firefox/mozilla-central/xpcom/io/nsWildCard.cpp", line 455.20: 1540-0700 (I) The previous message was produced while processing "NS_WildCardMatch_<unsigned short>(const unsigned short *, const unsigned short *, PRBool)". "/home/firefox/mozilla-central/xpcom/io/nsWildCard.cpp", line 470.12: 1540-0700 (I) The previous message was produced while processing "NS_WildCardMatch(const PRUnichar *, const PRUnichar *, PRBool)". Reproducible: Always Steps to Reproduce: 1.Build Mozilla Firefox 3.7a1pre build on AIX with Gnome RPMS of 64 bit version. 2. 3. Actual Results: Build fails with the above error. Expected Results: No build failure

I checked with compiler team for this issue and below is the explanation I received for the compiler behaviour. ' In the C++ Standard (ISO/IEC 14882), section 14.6.4.2 "Candidate functions" describes that: for an unqualified function call that depends on a template parameter, only function declarations with external linkage from the template definition context should be found. In this scenario the "static" function results in internal linkage and therefore cannot be found. One solution is to make the function non-static by removing "static". Alternatively we may make the function-call qualified. ' The patch submitted has taken alternate approach of making the function-call qualified.

Same as bug 524271

Took Shailen's patch, manually fixed the failed hunk #5 and recreated diff with hg. For 1.9.2 branch only.

Comment on attachment 427374 [details] [diff] [review] patch adjusted for 1.9.2 branch Clearing old approval requests now that 1.9.2.4 has shipped. If you believe this patch is still necessary on the 1.9.2 branch please re-request approval along with a risk/benefit analysis explaining why we need it.

Comment on attachment 427374 [details] [diff] [review] patch adjusted for 1.9.2 branch This bug isn't fixed on 1.9.2 branch yet. Risc: (very) close to none, baked on trunk now for half an year. Benefit: tb3.1 and ff36 on AIX 5.2 or later.

Comment on attachment 427374 [details] [diff] [review] patch adjusted for 1.9.2 branch Renewing approval request, the branch 192 patch still applies cleanly.

Comment on attachment 427374 [details] [diff] [review] patch adjusted for 1.9.2 branch Approved for 1.9.2.14, a=dveditz for release-drivers