Closed
Bug 526663
Opened 15 years ago
Closed 15 years ago
[Win7] Firefox shortcut icon remains in taskbar after uninstalling application
Categories
(Firefox :: Installer, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: marcia, Assigned: jimm)
References
Details
Attachments
(4 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
Seen while running the latest 1.9.2 nightly.
STR:
1. Install Namoroka build in the default directory.
2. Pin the app to the taskbar.
2. Run the uninstaller.
See the attached screenshot. We leave an icon behind in the taskbar after the uninstaller is run.
I tried the same STR using Google Chrome and that app did not leave anything behind.
Reporter | ||
Updated•15 years ago
|
Attachment #410401 -
Attachment description: Screenshot of shortcut icon → Screenshot of shortcut window
Reporter | ||
Comment 1•15 years ago
|
||
Reporter | ||
Updated•15 years ago
|
Summary: Firefox shortcut icon remains in taskbar after uninstalling application → [Win7] Firefox shortcut icon remains in taskbar after uninstalling application
Assignee | ||
Comment 2•15 years ago
|
||
I'm not sure if we can delete this, since it was based on a user action.
Assignee | ||
Updated•15 years ago
|
Blocks: win7support
Assignee | ||
Updated•15 years ago
|
Component: Installer: XPInstall Engine → Installer
Product: Core → Firefox
QA Contact: xpi-engine → installer
Version: 1.9.2 Branch → Trunk
Comment 3•15 years ago
|
||
We *might* be able to since there are a few hacks out there for working around the intentional lack of ability for installers to add / remove the taskbar shortcuts.
Comment 4•15 years ago
|
||
> Any shortcut installed by an application might have been subsequently pinned by the user, and there is no way for an application to know this. Therefore, we recommend that, during uninstallation, all applications call IStartMenuPinnedList::RemoveFromList on each shortcut they installed.
http://msdn.microsoft.com/en-us/library/bb774817.aspx
Assignee | ||
Comment 5•15 years ago
|
||
(In reply to comment #4)
> > Any shortcut installed by an application might have been subsequently pinned by the user, and there is no way for an application to know this. Therefore, we recommend that, during uninstallation, all applications call IStartMenuPinnedList::RemoveFromList on each shortcut they installed.
>
> http://msdn.microsoft.com/en-us/library/bb774817.aspx
Woot! We can add that to the uninstall. Thanks James!
Assignee | ||
Updated•15 years ago
|
OS: Windows NT → Windows 7
Assignee | ||
Comment 6•15 years ago
|
||
Assignee: nobody → jmathies
Assignee | ||
Comment 7•15 years ago
|
||
Attachment #442915 -
Attachment is obsolete: true
Attachment #443362 -
Flags: review?(robert.bugzilla)
Updated•15 years ago
|
Attachment #443362 -
Flags: review?(robert.bugzilla) → review+
Assignee | ||
Comment 8•15 years ago
|
||
ShellLink::GetShortCutTarget "$QUICKLAUNCH\$R8"
Pop $R5
StrCmp "$INSTDIR\${FileMainEXE}" "$R5" +1 -7
+ ApplicationID::UninstallPinnedItem "$QUICKLAUNCH\$R8"
Delete "$QUICKLAUNCH\$R8"
Rob, should I add pops after all of these UninstallPinnedItem calls?
Comment 9•15 years ago
|
||
Definitely if they change the registers from what they were before calling the macro.
Assignee | ||
Comment 10•15 years ago
|
||
Added Pop's to remove the result of ApplicationID::UninstallPinnedItem from the stack.
Assignee | ||
Comment 11•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•